ppapi/thunk/ppb_gamepad_thunk.cc - Issue 14161017: Pepper: Simplify idl_thunk implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/thunk/ppb_gamepad_thunk.cc

Issue 14161017: Pepper: Simplify idl_thunk implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: on_failure comment nit Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/thunk/ppb_gamepad_thunk.cc

diff --git a/ppapi/thunk/ppb_gamepad_thunk.cc b/ppapi/thunk/ppb_gamepad_thunk.cc

index e2f0160589bd6731f90406da25f91ab594b5385d..e36af34410685782554f0734393e3099b0cb0bd5 100644

--- a/ppapi/thunk/ppb_gamepad_thunk.cc

+++ b/ppapi/thunk/ppb_gamepad_thunk.cc

@@ -23,11 +23,11 @@ namespace {

void Sample(PP_Instance instance, struct PP_GamepadsSampleData* data) {

VLOG(4) << "PPB_Gamepad::Sample()";

EnterInstanceAPI<PPB_Gamepad_API> enter(instance);

- if (enter.succeeded()) {

- enter.functions()->Sample(instance, data);

+ if (enter.failed()) {

+ memset(data, 0, sizeof(*data));

return;

}

- memset(data, 0, sizeof(*data));

+ enter.functions()->Sample(instance, data);

}

const PPB_Gamepad_1_0 g_ppb_gamepad_thunk_1_0 = {

« no previous file with comments | « ppapi/thunk/ppb_find_dev_thunk.cc ('k') | ppapi/thunk/ppb_messaging_thunk.cc » ('j') | no next file with comments »