Move prefix_set and parts of safe_browsing_util into a new component safe_browsing_db.

components/safe_browsing_db/BUILD.gn

+# Copyright 2015 The Chromium Authors. All rights reserved.

[blundell, 2015/10/23 07:10:29]

You need to suppress the warning in this file as well as in
safe_browsing_db.gypi.

[vakh (old account. dont use), 2015/10/27 19:49:04]

Done.

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+group("safe_browsing_db") {
+  deps = [
+    ":prefix_set",
+    ":safe_browsing_db_util",
+  ]
+}
+
+source_set("prefix_set") {
+  sources = [
+    "prefix_set.cc",
+    "prefix_set.h",
+  ]
+  deps = [
+    "//base",
+  ]
+}
+
+source_set("safe_browsing_db_util") {

[blundell, 2015/10/23 07:10:29]

This is really a comment for the original CL, but: why a different structure
between this BUILD.gn file and safe_browsing_db.gypi?

[vakh (old account. dont use), 2015/10/27 19:49:04]

2 reasons:
1. I am more familiar with BUILD files so I could give it a better structure.
2. The BUILD.gn file is common between product code and tests so I can create
individual targets that both group("safe_browsing_db") and
source_set("unit_tests") can depend on. For .gyp, we have different files for
code and test so creating components for safe_browsing_util and prefix_set
didn't seem that useful.

+  sources = [
+    "safe_browsing_db_util.cc",
+    "safe_browsing_db_util.h",
+  ]
+  deps = [
+    "//base",
+    "//crypto",
+  ]
+}
+
+source_set("unit_tests") {
+  testonly = true
+  sources = [
+    "prefix_set_unittest.cc",
+    "safe_browsing_db_util_unittest.cc",
+  ]
+  deps = [
+    ":prefix_set",
+    ":safe_browsing_db_util",
+    "//base",
+    "//testing/gtest",
+  ]
+}