Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 1415773002: Don't change Document load progress in any page dismissal events. (Closed)

Created:
3 years, 10 months ago by dcheng
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

Don't change Document load progress in any page dismissal events. This can confuse the logic for blocking modal dialogs. BUG=536652 Review URL: https://codereview.chromium.org/1373113002 Cr-Commit-Position: refs/heads/master@{#351419} (cherry picked from commit e1e0c4301aaa8228e362f2409dbde2d4d1896866) Committed: https://chromium.googlesource.com/chromium/src/+/931acc8f51135cf1e52823fc6bfe6a93def085f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/events/alert-in-beforeunload-document-write.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/alert-in-beforeunload-document-write-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
dcheng
3 years, 10 months ago (2015-10-19 22:34:24 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
931acc8f51135cf1e52823fc6bfe6a93def085f7.

Powered by Google App Engine
This is Rietveld 408576698