Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373113002: Don't change Document load progress in any page dismissal events. (Closed)

Created:
5 years, 2 months ago by dcheng
Modified:
5 years, 2 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't change Document load progress in any page dismissal events. This can confuse the logic for blocking modal dialogs. BUG=536652 Committed: https://crrev.com/e1e0c4301aaa8228e362f2409dbde2d4d1896866 Cr-Commit-Position: refs/heads/master@{#351419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/events/alert-in-beforeunload-document-write.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/alert-in-beforeunload-document-write-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 2 months ago (2015-09-28 23:33:04 UTC) #2
Nate Chapin
lgtm
5 years, 2 months ago (2015-09-29 21:42:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373113002/1
5 years, 2 months ago (2015-09-29 22:03:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 22:28:33 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 22:31:14 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e1e0c4301aaa8228e362f2409dbde2d4d1896866
Cr-Commit-Position: refs/heads/master@{#351419}

Powered by Google App Engine
This is Rietveld 408576698