Issue 1415773002: Don't change Document load progress in any page dismissal events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1415773002: Don't change Document load progress in any page dismissal events. (Closed)

Created:
5 years, 2 months ago by dcheng

Modified:
5 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2490

Target Ref:
refs/pending/branch-heads/2490

Project:
chromium

Visibility:
Public.

Don't change Document load progress in any page dismissal events. This can confuse the logic for blocking modal dialogs. BUG=536652 Review URL: https://codereview.chromium.org/1373113002 Cr-Commit-Position: refs/heads/master@{#351419} (cherry picked from commit e1e0c4301aaa8228e362f2409dbde2d4d1896866) Committed: https://chromium.googlesource.com/chromium/src/+/931acc8f51135cf1e52823fc6bfe6a93def085f7

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -1 line)			Patch
A	third_party/WebKit/LayoutTests/fast/events/alert-in-beforeunload-document-write.html	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/events/alert-in-beforeunload-document-write-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/Document.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

dcheng

5 years, 2 months ago (2015-10-19 22:34:24 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
931acc8f51135cf1e52823fc6bfe6a93def085f7.