Issue 1415743013: Run jshint over all JavaScript files

Issue 1415743013: Run jshint over all JavaScript files (Closed)

Created:
5 years, 1 month ago by Sam Clegg

Modified:
5 years, 1 month ago

Reviewers:
bradnelson

CC:
native-client-reviews_googlegroups.com, Sam Clegg

Base URL:
https://chromium.googlesource.com/external/naclports.git@repo_conf

Target Ref:
refs/heads/master

Project:
naclports

Visibility:
Public.

More Reviews

Description

Run jshint over all JavaScript files Add dependency on npm and install jshint during runhooks. Run jshint over all JavaScript files using "make jshint", or "make lint" which runs all linters. Take a first pass add fixing or disabling all jshint warning. There are still many issues with our use of JavaScript but this change fixes a lot of the low hanging fruit. Committed: https://chromium.googlesource.com/external/naclports/+/d5cb5b4399ea34746d0866d38efc35168fc45414

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+308 lines, -180 lines)			Patch
M	.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	.jshintignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	.jshintrc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	Makefile	View		3 chunks	+11 lines, -2 lines	0 comments	Download
M	build_tools/naclprocess.js	View	1 2 3 4	12 chunks	+27 lines, -22 lines	0 comments	Download
M	build_tools/naclterm.js	View		14 chunks	+18 lines, -16 lines	0 comments	Download
M	build_tools/pipeserver.js	View		8 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome_test/chrome_test.js	View		7 chunks	+23 lines, -19 lines	0 comments	Download
M	chrome_test/tcpapp/tcp.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome_test/tests/extension_test.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome_test/tests/processes_test.js	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome_test/tests/user_agent_test.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	package.json	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ports/civetweb/civetweb.js	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	ports/curl/curl.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ports/devenv/background.js	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	ports/devenv/bash.js	View		3 chunks	+8 lines, -2 lines	0 comments	Download
M	ports/devenv/devenv.js	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	ports/devenv/devenvwidget/demo.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ports/devenv/devenvwidget/devenvwidget.js	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	ports/devenv/mounter.js	View	1 2 3 4	8 chunks	+11 lines, -11 lines	0 comments	Download
M	ports/devenv/tests/common.js	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	ports/devenv/tests/devenv_large_test.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ports/devenv/tests/devenv_small_test.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ports/devenv/tests/io2014_test.js	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	ports/devenv/tests/jseval_test.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	ports/emacs-x/Xsdl.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ports/gdb/background.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ports/gdb/extension/background.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ports/gdb/extension/main.js	View		6 chunks	+8 lines, -6 lines	0 comments	Download
M	ports/gdb/tests/common.js	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	ports/gdb/tests/debugger_test.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ports/gdb/tests/gdb_background_test.js	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	ports/gforth/gforth.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	ports/gimp-app/Xsdl.js	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	ports/gimp-app/background.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ports/gtk-demo/Xsdl.js	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	ports/libgit2-demo/libgit2.js	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	ports/lua/lua.js	View		5 chunks	+12 lines, -8 lines	0 comments	Download
M	ports/mongoose/mongoose.js	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	ports/python/python.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ports/python3/python.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ports/quakespasm/quakespasm.js	View		3 chunks	+10 lines, -6 lines	0 comments	Download
M	ports/ruby-ppapi/ruby.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ports/scummvm/packaged_app/background.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ports/snes9x/snes9x.js	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	ports/thttpd/nacl.js	View		5 chunks	+36 lines, -29 lines	0 comments	Download
M	ports/vim/vim.js	View		4 chunks	+8 lines, -6 lines	0 comments	Download
M	ports/xorg-server/background.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download