Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: ports/gdb/extension/main.js

Issue 1415743013: Run jshint over all JavaScript files (Closed) Base URL: https://chromium.googlesource.com/external/naclports.git@repo_conf
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ports/gdb/extension/background.js ('k') | ports/gdb/tests/common.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ports/gdb/extension/main.js
diff --git a/ports/gdb/extension/main.js b/ports/gdb/extension/main.js
index 2c4ebb71a0aa3596e633d3e378d7cb6ace38ad2a..31ebd7d3a42701fce4bb6d564d87851938fe9149 100644
--- a/ports/gdb/extension/main.js
+++ b/ports/gdb/extension/main.js
@@ -4,6 +4,8 @@
* found in the LICENSE file.
*/
+/* globals lib, hterm */
+
'use strict';
// The devtools page for the debugger.
@@ -44,7 +46,7 @@ GdbTerm.prototype.onTerminalResize_ = function(width, height) {
moduleList.firstChild.selected = true;
updateSelection();
}
-}
+};
/**
* Handle a keystroke from the user.
@@ -55,7 +57,7 @@ GdbTerm.prototype.onVTKeystroke_ = function(str) {
'name': 'input',
'msg': {'gdb': str},
});
-}
+};
/**
* Setup handlers after terminal start.
@@ -63,7 +65,7 @@ GdbTerm.prototype.onVTKeystroke_ = function(str) {
GdbTerm.prototype.run = function() {
this.io_.onVTKeystroke = this.onVTKeystroke_.bind(this);
this.io_.onTerminalResize = this.onTerminalResize_.bind(this);
-}
+};
/**
@@ -316,7 +318,7 @@ function handleChange(msg) {
!settings.onFaultAttach;
document.getElementById('showGdb').checked = settings.showGdb;
- function Visible(processId) {
+ function isVisible(processId) {
if (!(processId in modules)) {
return false;
}
@@ -325,14 +327,14 @@ function handleChange(msg) {
for (var i = 0; i < moduleList.childNodes.length; i++) {
var child = moduleList.childNodes[i];
- if (!Visible(child.id)) {
+ if (!isVisible(child.id)) {
moduleList.removeChild(child);
--i;
}
}
for (var processId in modules) {
var module = modules[processId];
- if (!Visible(processId))
+ if (!isVisible(processId))
continue;
var item = document.getElementById(processId);
if (item === null) {
« no previous file with comments | « ports/gdb/extension/background.js ('k') | ports/gdb/tests/common.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698