Makefile - Issue 1415743013: Run jshint over all JavaScript files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Makefile

Issue 1415743013: Run jshint over all JavaScript files (Closed) Base URL: https://chromium.googlesource.com/external/naclports.git@repo_conf

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Makefile

diff --git a/Makefile b/Makefile

index b8193bf5d40070d715a32f915441940f2bcc17f6..b769d5559ef44702b2162a9bd309054eb0582e1e 100644

--- a/Makefile

+++ b/Makefile

@@ -12,6 +12,7 @@

# at out/sentinels/*

PYLINT = build_tools/python_wrapper -m pylint

+JSHINT = nodejs node_modules/.bin/jshint

COVERAGE = bin/coverage

COVERAGE_ARGS = --fail-under=60

COVERAGE_VER := $(shell $(COVERAGE) --version 2>/dev/null)

@@ -62,9 +63,16 @@ reallyclean: clean

check: test

-lint:

+JS_FILES := $(shell git ls-files "*.js")

+lint: pylint jshint

+pylint:

$(PYLINT) --rcfile=.pylintrc lib/naclports lib/naclports/tests/*.py

+jshint:

+ $(JSHINT) $(JS_FILES)

test:

$(COVERAGE) run --include=lib/naclports/*,build_tools/* -m nose \

--rednose build_tools lib

@@ -75,4 +83,5 @@ test:

bin/naclports install $* $(BUILD_FLAGS)

-.PHONY: all run clean sdklibs sdklibs_list reallyclean check test lint

+.PHONY: all run clean sdklibs sdklibs_list reallyclean check test

+.PHONY: lint pylint jshint

« no previous file with comments | « .jshintrc ('k') | build_tools/naclprocess.js » ('j') | no next file with comments »