Added web-exposed constructor for Touch and TouchEvent

Added web-exposed constructor for Touch and TouchEvent

Added internal constructor for TouchList from a vector of Touch

Able to use syntax "new Touch(...)" and "new TouchEvent(...)" to initialize instead of "document.createTouch"

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9cyKla2YbcA

BUG=508675
TEST=https://github.com/w3c/web-platform-tests/pull/2299

SPEC=https://w3c.github.io/touch-events/#touch-interface

TODO: Remove layout tests and import w3c tests once it's approved. See http://crbug.com/552530

Committed: https://crrev.com/3b9cbfb56b50dba70fc07ce6bbf2212bd7854674
Cr-Commit-Position: refs/heads/master@{#359371}

[chongz, 2015-11-03 21:38:11]

Description was changed from

==========
Added web-exposed constructor for Touch and TouchEvent


Added internal constructor for TouchList from a vector of Touch


Able to use syntax "new Touch(...)" and "new TouchEvent(...)" to initialize
instead of "document.createTouch"


BUG=508675


TEST=https://github.com/w3c/web-platform-tests/pull/2299


SPEC=https://w3c.github.io/touch-events/#touch-interface
==========

to

==========
Added web-exposed constructor for Touch and TouchEvent


Added internal constructor for TouchList from a vector of Touch


Able to use syntax "new Touch(...)" and "new TouchEvent(...)" to initialize
instead of "document.createTouch"


BUG=508675


TEST=https://github.com/w3c/web-platform-tests/pull/2299


SPEC=https://w3c.github.io/touch-events/#touch-interface
==========

[chongz, 2015-11-03 21:38:12]

chongz@chromium.org changed reviewers:
+ dtapuska@chromium.org, rbyers@chromium.org

[dtapuska, 2015-11-04 16:29:43]

https://codereview.chromium.org/1415673004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/TouchList.h (right):

https://codereview.chromium.org/1415673004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/TouchList.h:51: for (size_t i = 0; i <
touchCount; ++i) {
Remove braces; and you should be able to use a range based for loop.
(http://en.cppreference.com/w/cpp/language/range-for)

I think HeapVector exposes begin/end..

[sof, 2015-11-04 16:38:28]

https://codereview.chromium.org/1415673004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/TouchList.h (right):

https://codereview.chromium.org/1415673004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/TouchList.h:51: for (size_t i = 0; i <
touchCount; ++i) {
On 2015/11/04 16:29:43, dtapuska wrote:
> Remove braces; and you should be able to use a range based for loop.
> (http://en.cppreference.com/w/cpp/language/range-for)
> 
> I think HeapVector exposes begin/end..

list->m_values.appendVector(touches); is shorter, and preferable.

[dtapuska, 2015-11-04 21:36:32]

https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/events/constructors/create-touch-touchlist.html
(right):

https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/constructors/create-touch-touchlist.html:2:
TODO(chongz): Remove this file and import from w3c tests after approved.
Pls reference the crbug

https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/events/constructors/touch-support.js
(right):

https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/constructors/touch-support.js:1: // 
TODO(chongz): Remove this file and import from w3c tests after approved.
ditto

https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html
(right):

https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html:2:
TODO(chongz): Remove this file and import from w3c tests after approved.
same

https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html:41:
pageX: 15,
Should we verify that these are parsed as double values and not longs?

Do we care about these being normal doubles and (not-unrestricted)?

Should we verify the default values?
Should we make sure exceptions are thrown when the required values aren't
provided?

https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html:94:
assert_equals(touchEvent1.touches.length, 2, "touchEvent.touches.length is
requested value");
I'd expect the length checks first before accessing the indicies; on this and
below.

[chongz, 2015-11-06 19:53:29]

On 2015/11/04 21:36:32, dtapuska wrote:
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/fast/events/constructors/create-touch-touchlist.html
> (right):
> 
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/events/constructors/create-touch-touchlist.html:2:
> TODO(chongz): Remove this file and import from w3c tests after approved.
> Pls reference the crbug
> 
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/fast/events/constructors/touch-support.js
> (right):
> 
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/events/constructors/touch-support.js:1: //

> TODO(chongz): Remove this file and import from w3c tests after approved.
> ditto
> 
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html
> (right):
> 
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html:2:
> TODO(chongz): Remove this file and import from w3c tests after approved.
> same
> 
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html:41:
> pageX: 15,
> Should we verify that these are parsed as double values and not longs?
> 
> Do we care about these being normal doubles and (not-unrestricted)?
> 
> Should we verify the default values?
> Should we make sure exceptions are thrown when the required values aren't
> provided?
> 
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html:94:
> assert_equals(touchEvent1.touches.length, 2, "touchEvent.touches.length is
> requested value");
> I'd expect the length checks first before accessing the indicies; on this and
> below.

Thanks for the review! I've updated the reference link, tests with normal double
value, exception tests with/without required values and tests order.

[chongz, 2015-11-09 16:20:40]

Description was changed from

==========
Added web-exposed constructor for Touch and TouchEvent


Added internal constructor for TouchList from a vector of Touch


Able to use syntax "new Touch(...)" and "new TouchEvent(...)" to initialize
instead of "document.createTouch"


BUG=508675


TEST=https://github.com/w3c/web-platform-tests/pull/2299


SPEC=https://w3c.github.io/touch-events/#touch-interface
==========

to

==========
Added web-exposed constructor for Touch and TouchEvent


Added internal constructor for TouchList from a vector of Touch


Able to use syntax "new Touch(...)" and "new TouchEvent(...)" to initialize
instead of "document.createTouch"


BUG=508675


TEST=https://github.com/w3c/web-platform-tests/pull/2299


SPEC=https://w3c.github.io/touch-events/#touch-interface


TODO: Remove layout tests and import w3c tests once it's approved. See
http://crbug.com/552530
==========

[dtapuska, 2015-11-09 17:45:45]

On 2015/11/06 19:53:29, chongz wrote:
> On 2015/11/04 21:36:32, dtapuska wrote:
> >
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> > File
> >
>
third_party/WebKit/LayoutTests/fast/events/constructors/create-touch-touchlist.html
> > (right):
> > 
> >
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> >
>
third_party/WebKit/LayoutTests/fast/events/constructors/create-touch-touchlist.html:2:
> > TODO(chongz): Remove this file and import from w3c tests after approved.
> > Pls reference the crbug
> > 
> >
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> > File
third_party/WebKit/LayoutTests/fast/events/constructors/touch-support.js
> > (right):
> > 
> >
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> > third_party/WebKit/LayoutTests/fast/events/constructors/touch-support.js:1:
//
> 
> > TODO(chongz): Remove this file and import from w3c tests after approved.
> > ditto
> > 
> >
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> > File
> >
>
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html
> > (right):
> > 
> >
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> >
>
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html:2:
> > TODO(chongz): Remove this file and import from w3c tests after approved.
> > same
> > 
> >
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> >
>
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html:41:
> > pageX: 15,
> > Should we verify that these are parsed as double values and not longs?
> > 
> > Do we care about these being normal doubles and (not-unrestricted)?
> > 
> > Should we verify the default values?
> > Should we make sure exceptions are thrown when the required values aren't
> > provided?
> > 
> >
>
https://codereview.chromium.org/1415673004/diff/20001/third_party/WebKit/Layo...
> >
>
third_party/WebKit/LayoutTests/fast/events/constructors/touch-touchevent-constructor.html:94:
> > assert_equals(touchEvent1.touches.length, 2, "touchEvent.touches.length is
> > requested value");
> > I'd expect the length checks first before accessing the indicies; on this
and
> > below.
> 
> Thanks for the review! I've updated the reference link, tests with normal
double
> value, exception tests with/without required values and tests order.

non owner; lgtm

[Rick Byers, 2015-11-10 06:31:51]

Looks great, thanks!  Just one little thing, then we need to wait for the
intent-to-ship to pass (which I expect it will without issue, except that
everyone is busy at BlinkOn so it'll take a little while).

https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Touch.idl (right):

https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Touch.idl:31: RuntimeEnabled=Touch,
Since this wasn't RuntimeEnabled before (and TouchEvent itself still isn't
RuntimeEnabled), let's not make it RuntimeEnabled now.

In particular, a page may have a good reason to create synthetic touch events in
JS even though window.ontouchstart doesn't exist etc.

https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/TouchInit.idl (right):

https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/TouchInit.idl:8: RuntimeEnabled=Touch,
also no reason to be RuntimeEnabled.
See https://code.google.com/p/chromium/issues/detail?id=392584 for some
background here.

[chongz, 2015-11-10 15:52:17]

Description was changed from

==========
Added web-exposed constructor for Touch and TouchEvent


Added internal constructor for TouchList from a vector of Touch


Able to use syntax "new Touch(...)" and "new TouchEvent(...)" to initialize
instead of "document.createTouch"


BUG=508675


TEST=https://github.com/w3c/web-platform-tests/pull/2299


SPEC=https://w3c.github.io/touch-events/#touch-interface


TODO: Remove layout tests and import w3c tests once it's approved. See
http://crbug.com/552530
==========

to

==========
Added web-exposed constructor for Touch and TouchEvent


Added internal constructor for TouchList from a vector of Touch


Able to use syntax "new Touch(...)" and "new TouchEvent(...)" to initialize
instead of "document.createTouch"

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9cyKla2YbcA


BUG=508675


TEST=https://github.com/w3c/web-platform-tests/pull/2299


SPEC=https://w3c.github.io/touch-events/#touch-interface


TODO: Remove layout tests and import w3c tests once it's approved. See
http://crbug.com/552530
==========

[blink-reviews, 2015-11-10 16:05:42]

Thanks! Ya I agree with no RuntimeEnabled here, looks more simple and clear
to me.

On Tue, Nov 10, 2015 at 1:31 AM <rbyers@chromium.org> wrote:

> Looks great, thanks!  Just one little thing, then we need to wait for the
> intent-to-ship to pass (which I expect it will without issue, except that
> everyone is busy at BlinkOn so it'll take a little while).
>
>
>
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/Touch.idl (right):
>
>
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/Touch.idl:31
>
<https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...>:
> RuntimeEnabled=Touch,
> Since this wasn't RuntimeEnabled before (and TouchEvent itself still
> isn't RuntimeEnabled), let's not make it RuntimeEnabled now.
>
> In particular, a page may have a good reason to create synthetic touch
> events in JS even though window.ontouchstart doesn't exist etc.
>
>
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/TouchInit.idl (right):
>
>
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/TouchInit.idl:8
>
<https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...>
> :
> RuntimeEnabled=Touch,
> also no reason to be RuntimeEnabled.
> See https://code.google.com/p/chromium/issues/detail?id=392584 for some
> background here.
>
> https://codereview.chromium.org/1415673004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2015-11-10 16:05:42]

Thanks! Ya I agree with no RuntimeEnabled here, looks more simple and clear
to me.

On Tue, Nov 10, 2015 at 1:31 AM <rbyers@chromium.org> wrote:

> Looks great, thanks!  Just one little thing, then we need to wait for the
> intent-to-ship to pass (which I expect it will without issue, except that
> everyone is busy at BlinkOn so it'll take a little while).
>
>
>
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/Touch.idl (right):
>
>
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/Touch.idl:31
>
<https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...>:
> RuntimeEnabled=Touch,
> Since this wasn't RuntimeEnabled before (and TouchEvent itself still
> isn't RuntimeEnabled), let's not make it RuntimeEnabled now.
>
> In particular, a page may have a good reason to create synthetic touch
> events in JS even though window.ontouchstart doesn't exist etc.
>
>
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/TouchInit.idl (right):
>
>
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/TouchInit.idl:8
>
<https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...>
> :
> RuntimeEnabled=Touch,
> also no reason to be RuntimeEnabled.
> See https://code.google.com/p/chromium/issues/detail?id=392584 for some
> background here.
>
> https://codereview.chromium.org/1415673004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dtapuska, 2015-11-12 18:29:27]

On 2015/11/10 16:05:42, chromium-reviews wrote:
> Thanks! Ya I agree with no RuntimeEnabled here, looks more simple and clear
> to me.
> 
> On Tue, Nov 10, 2015 at 1:31 AM <mailto:rbyers@chromium.org> wrote:
> 
> > Looks great, thanks!  Just one little thing, then we need to wait for the
> > intent-to-ship to pass (which I expect it will without issue, except that
> > everyone is busy at BlinkOn so it'll take a little while).
> >
> >
> >
> >
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/core/dom/Touch.idl (right):
> >
> >
> >
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/core/dom/Touch.idl:31
> >
>
<https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...>:
> > RuntimeEnabled=Touch,
> > Since this wasn't RuntimeEnabled before (and TouchEvent itself still
> > isn't RuntimeEnabled), let's not make it RuntimeEnabled now.
> >
> > In particular, a page may have a good reason to create synthetic touch
> > events in JS even though window.ontouchstart doesn't exist etc.
> >
> >
> >
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/core/dom/TouchInit.idl (right):
> >
> >
> >
>
https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/core/dom/TouchInit.idl:8
> >
>
<https://codereview.chromium.org/1415673004/diff/60001/third_party/WebKit/Sour...>
> > :
> > RuntimeEnabled=Touch,
> > also no reason to be RuntimeEnabled.
> > See https://code.google.com/p/chromium/issues/detail?id=392584 for some
> > background here.
> >
> > https://codereview.chromium.org/1415673004/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

non-owner; lgtm

[Rick Byers, 2015-11-12 18:56:07]

Description was changed from

==========
Added web-exposed constructor for Touch and TouchEvent


Added internal constructor for TouchList from a vector of Touch


Able to use syntax "new Touch(...)" and "new TouchEvent(...)" to initialize
instead of "document.createTouch"

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9cyKla2YbcA


BUG=508675


TEST=https://github.com/w3c/web-platform-tests/pull/2299


SPEC=https://w3c.github.io/touch-events/#touch-interface


TODO: Remove layout tests and import w3c tests once it's approved. See
http://crbug.com/552530
==========

to

==========
Added web-exposed constructor for Touch and TouchEvent

Added internal constructor for TouchList from a vector of Touch

Able to use syntax "new Touch(...)" and "new TouchEvent(...)" to initialize
instead of "document.createTouch"

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9cyKla2YbcA

BUG=508675

TEST=https://github.com/w3c/web-platform-tests/pull/2299

SPEC=https://w3c.github.io/touch-events/#touch-interface

TODO: Remove layout tests and import w3c tests once it's approved. See
http://crbug.com/552530
==========

[Rick Byers, 2015-11-12 18:56:24]

LGTM, thanks!

[chongz, 2015-11-12 19:04:19]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2015-11-12 19:05:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415673004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415673004/80001

[commit-bot: I haz the power, 2015-11-12 20:18:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-12 20:19:00]

Patchset 5 (id:??) landed as
https://crrev.com/3b9cbfb56b50dba70fc07ce6bbf2212bd7854674
Cr-Commit-Position: refs/heads/master@{#359371}