Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: snapshot/module_snapshot.h

Issue 1415543003: win: Plumb module PDB name through snapshot (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: snapshot/module_snapshot.h
diff --git a/snapshot/module_snapshot.h b/snapshot/module_snapshot.h
index 6c397ed0a71e6210f988807d8ffea5e9b14ff340..189c1d7319a5cbfe3dd729993fb3281e15ae2655 100644
--- a/snapshot/module_snapshot.h
+++ b/snapshot/module_snapshot.h
@@ -120,6 +120,13 @@ class ModuleSnapshot {
//! `0`.
Mark Mentovai 2015/10/28 20:01:10 //! \sa DebugFileName()
scottmg 2015/10/28 20:59:25 Done.
virtual void UUIDAndAge(crashpad::UUID* uuid, uint32_t* age) const = 0;
+ //! \brief Returns the module’s PDB link name.
+ //!
+ //! On Windows, the PDB contains symbol information, held separately from the
+ //! module itself. On other platforms, this should just be the basename of the
Mark Mentovai 2015/10/28 20:01:10 “should” → “is normally”
scottmg 2015/10/28 20:59:25 Done.
+ //! module.
Mark Mentovai 2015/10/28 20:01:10 “, because the debug info file’s name is not relev
Mark Mentovai 2015/10/28 20:01:11 //! \sa UUIDAndAge()
scottmg 2015/10/28 20:59:25 Done.
scottmg 2015/10/28 20:59:25 Done.
+ virtual std::string PDBName() const = 0;
Mark Mentovai 2015/10/28 20:01:10 Let’s try to keep things more generic in snapshot,
scottmg 2015/10/28 20:59:24 Done.
+
//! \brief Returns string annotations recorded in the module.
//!
//! This method retrieves annotations recorded in a module. These annotations

Powered by Google App Engine
This is Rietveld 408576698