win: Plumb module PDB name through snapshot

snapshot/module_snapshot.h

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 99 matching lines @@
   virtual ModuleType GetModuleType() const = 0;
 
   //! \brief Returns the module’s UUID in the \a uuid parameter, and the age of
   //!     that UUID in \a age.
   //!
   //! A snapshot module’s UUID is taken directly from the module itself. If the
   //! module does not have a UUID, the \a uuid parameter will be zeroed out.
   //!
   //! \a age is the number of times the UUID has been reused. This occurs on
   //! Windows with incremental linking. On other platforms \a age will always be
   //! `0`.

[Mark Mentovai, 2015/10/28 20:01:10]

//! \sa DebugFileName()

[scottmg, 2015/10/28 20:59:25]

Done.

   virtual void UUIDAndAge(crashpad::UUID* uuid, uint32_t* age) const = 0;
 
+  //! \brief Returns the module’s PDB link name.
+  //!
+  //! On Windows, the PDB contains symbol information, held separately from the
+  //! module itself. On other platforms, this should just be the basename of the

[Mark Mentovai, 2015/10/28 20:01:10]

“should” → “is normally”

[scottmg, 2015/10/28 20:59:25]

Done.

+  //! module.

[Mark Mentovai, 2015/10/28 20:01:10]

“, because the debug info file’s name is not relevant even in split-debug
scenarios.”

[Mark Mentovai, 2015/10/28 20:01:11]

//! \sa UUIDAndAge()

[scottmg, 2015/10/28 20:59:25]

Done.

[scottmg, 2015/10/28 20:59:25]

Done.

+  virtual std::string PDBName() const = 0;

[Mark Mentovai, 2015/10/28 20:01:10]

Let’s try to keep things more generic in snapshot, like DebugFileName(). Applies
to the \brief on line 123 too.

[scottmg, 2015/10/28 20:59:24]

Done.

+
   //! \brief Returns string annotations recorded in the module.
   //!
   //! This method retrieves annotations recorded in a module. These annotations
   //! are intended for diagnostic use, including crash analysis. A module may
   //! contain multiple annotations, so they are returned in a vector.
   //!
   //! For Mac OS X snapshots, these annotations are found by interpreting the
   //! module’s `__DATA, __crash_info` section as `crashreporter_annotations_t`.
   //! System libraries using the crash reporter client interface may reference
   //! annotations in this structure. Additional annotations messages may be
@@ skipping 21 matching lines @@
   //! The annotations returned by this method do not duplicate those returned by
   //! AnnotationsVector(). Additional annotations related to the process,
   //! system, or snapshot producer may be obtained by calling
   //! ProcessSnapshot::AnnotationsSimpleMap().
   virtual std::map<std::string, std::string> AnnotationsSimpleMap() const = 0;
 };
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_SNAPSHOT_MODULE_SNAPSHOT_H_