Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: snapshot/mac/module_snapshot_mac.cc

Issue 1415543003: win: Plumb module PDB name through snapshot (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: snapshot/mac/module_snapshot_mac.cc
diff --git a/snapshot/mac/module_snapshot_mac.cc b/snapshot/mac/module_snapshot_mac.cc
index 7ddf217d0d0be8f3228dee467682224e5acdca44..939631b7df87955d464a75e678d5f1f150377a74 100644
--- a/snapshot/mac/module_snapshot_mac.cc
+++ b/snapshot/mac/module_snapshot_mac.cc
@@ -156,6 +156,15 @@ void ModuleSnapshotMac::UUIDAndAge(crashpad::UUID* uuid, uint32_t* age) const {
*age = 0;
}
+void ModuleSnapshotMac::PDBName() const {
+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ std::string name = Name();
Mark Mentovai 2015/10/28 20:01:10 Now that we’re in platform-specific code where we
scottmg 2015/10/28 20:59:24 Done.
+ size_t last_slash = name.find_last_of('/');
+ if (last_slash != std::string::npos)
+ return name.substr(last_slash + 1);
+ return name;
+}
+
std::vector<std::string> ModuleSnapshotMac::AnnotationsVector() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
MachOImageAnnotationsReader annotations_reader(

Powered by Google App Engine
This is Rietveld 408576698