Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1415543002: Remove redundant FaviconDriverImpl::large_icon_handler_ on Android (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 1 month ago
Reviewers:
huangs
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@initial_simplify
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant FaviconDriverImpl::large_icon_handler_ on Android When the Icon NTP is enabled on Android, FaviconDriverImpl creates two identical FaviconHandlers: |FaviconDriver::touch_icon_handler_| and |FaviconDriver::large_icon_handler_|. This CL removes |FaviconDriver::large_icon_handler_| because it is redundant. BUG=None Committed: https://crrev.com/00f98d85ceb689e71f05e88d46df71acbd2b7393 Cr-Commit-Position: refs/heads/master@{#356306}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M components/favicon/core/favicon_driver_impl.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M components/favicon/core/favicon_driver_impl.cc View 1 5 chunks +1 line, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
pkotwicz
huangs@ can you please take a look? My understanding is that there is serious discussion ...
5 years, 2 months ago (2015-10-18 21:57:21 UTC) #2
pkotwicz
huangs@ Ping!
5 years, 1 month ago (2015-10-26 15:26:20 UTC) #3
huangs
LGTM.
5 years, 1 month ago (2015-10-26 19:16:51 UTC) #5
huangs
Please update the tile and description though.
5 years, 1 month ago (2015-10-26 19:17:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415543002/20001
5 years, 1 month ago (2015-10-27 15:15:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 15:56:09 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 15:57:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00f98d85ceb689e71f05e88d46df71acbd2b7393
Cr-Commit-Position: refs/heads/master@{#356306}

Powered by Google App Engine
This is Rietveld 408576698