Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1412033002: Make logic in OnFaviconDataForInitialURLFromFaviconService() the same for touch & non-touch favicons (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_notifications
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make logic in OnFaviconDataForInitialURLFromFaviconService() the same for touch & non-touch favicons BUG=542057 Committed: https://crrev.com/d480ea1df905c9f7b5566b70f9fa92cfdde1c228 Cr-Commit-Position: refs/heads/master@{#356062}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M components/favicon/core/favicon_handler.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/favicon/core/favicon_handler.cc View 1 6 chunks +20 lines, -23 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
pkotwicz
Scott, can you please take a look?
5 years, 2 months ago (2015-10-18 21:19:59 UTC) #2
sky
LGTM
5 years, 2 months ago (2015-10-19 15:34:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412033002/20001
5 years, 1 month ago (2015-10-26 16:11:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 16:51:57 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 16:52:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d480ea1df905c9f7b5566b70f9fa92cfdde1c228
Cr-Commit-Position: refs/heads/master@{#356062}

Powered by Google App Engine
This is Rietveld 408576698