Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: components/favicon/core/favicon_driver_impl.h

Issue 1415543002: Remove redundant FaviconDriverImpl::large_icon_handler_ on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/favicon/core/favicon_driver_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 82
83 FaviconService* favicon_service() { return favicon_service_; } 83 FaviconService* favicon_service() { return favicon_service_; }
84 84
85 private: 85 private:
86 // KeyedServices used by FaviconDriverImpl. They may be null during testing, 86 // KeyedServices used by FaviconDriverImpl. They may be null during testing,
87 // but if they are defined, they must outlive the FaviconDriverImpl. 87 // but if they are defined, they must outlive the FaviconDriverImpl.
88 FaviconService* favicon_service_; 88 FaviconService* favicon_service_;
89 history::HistoryService* history_service_; 89 history::HistoryService* history_service_;
90 bookmarks::BookmarkModel* bookmark_model_; 90 bookmarks::BookmarkModel* bookmark_model_;
91 91
92 // FaviconHandlers used to download the different kind of favicons. Both 92 // FaviconHandlers used to download the different kind of favicons.
93 // |touch_icon_handler_| and |large_icon_handler_| may be null depending 93 // |touch_icon_handler_| may be null depending on the platform and variations.
94 // on the platform or variations.
95 scoped_ptr<FaviconHandler> favicon_handler_; 94 scoped_ptr<FaviconHandler> favicon_handler_;
96 scoped_ptr<FaviconHandler> touch_icon_handler_; 95 scoped_ptr<FaviconHandler> touch_icon_handler_;
97 scoped_ptr<FaviconHandler> large_icon_handler_;
98 96
99 DISALLOW_COPY_AND_ASSIGN(FaviconDriverImpl); 97 DISALLOW_COPY_AND_ASSIGN(FaviconDriverImpl);
100 }; 98 };
101 99
102 } // namespace favicon 100 } // namespace favicon
103 101
104 #endif // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_ 102 #endif // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | components/favicon/core/favicon_driver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698