[Media Router] Use common media-router-header for MR UI.

[Media Router] Use common media-router-header for MR UI.

Uses a common media-router-header for all of Media Router WebUI, which now lives in media-router-container.

Time it takes from toolbar icon pressed to UI initialized (average 10 trials):
Before changes: 1031.492ms
After changes: 952.137ms

Number of elements on lab network (before / after setting data):
Before changes: 163 / 601
After changes: 121 / 523

BUG=549289
Committed: https://crrev.com/34b9c5e95141c667baaabb1b22c790b5797639af
Cr-Commit-Position: refs/heads/master@{#358731}

[apacible, 2015-11-04 18:41:44]

Patchset #1 (id:1) has been deleted

[apacible, 2015-11-04 18:46:31]

Description was changed from

==========
update media-router-header

BUG=
==========

to

==========
[Media Router] Add conditional templating to media-router-header.

Adds conditional templating to media-router-header. Each header is not expected
to change views once it's initially set. Stamping unused elements is not
necessary. Wrapping it in conditional templating (dom-if) reduces the number of
elements on page load as well as the time it takes to initialize.

Time it takes from toolbar icon pressed to UI initialized (average 10 trials):
Before changes: 1026.4322ms
After changes: 939.7326ms

Number of elements on lab network (before / after setting data):
Before changes: 163 / 601
After changes: 149 / 587

BUG=549289
==========

[apacible, 2015-11-04 18:46:31]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2015-11-04 18:47:12]

PTAL, thanks!

[imcheng, 2015-11-04 22:05:41]

Discussed offline: the fact that we have multiple media-router-header across
different elements (media-router-container, issue-banner, route-details) but
that only at most one of them is shown at any given time suggests that there is
more room for optimization in the higher level, i.e., the media-router-header
can be shared across multiple views. 

Right now we are actually stamping 2 media-router-header on startup due to the
extra one in route-details. Sharing the header should in theory speed up since
now we would have fewer elements to stamp and fewer computations related to
media-router-header.

[apacible, 2015-11-06 23:10:54]

Patchset #2 (id:40001) has been deleted

[apacible, 2015-11-06 23:56:35]

Description was changed from

==========
[Media Router] Add conditional templating to media-router-header.

Adds conditional templating to media-router-header. Each header is not expected
to change views once it's initially set. Stamping unused elements is not
necessary. Wrapping it in conditional templating (dom-if) reduces the number of
elements on page load as well as the time it takes to initialize.

Time it takes from toolbar icon pressed to UI initialized (average 10 trials):
Before changes: 1026.4322ms
After changes: 939.7326ms

Number of elements on lab network (before / after setting data):
Before changes: 163 / 601
After changes: 149 / 587

BUG=549289
==========

to

==========
[Media Router] Add conditional templating to media-router-header.

Adds conditional templating to media-router-header. Each header is not expected
to change views once it's initially set. Stamping unused elements is not
necessary. Wrapping it in conditional templating (dom-if) reduces the number of
elements on page load as well as the time it takes to initialize.

Time it takes from toolbar icon pressed to UI initialized (average 10 trials):
Before changes: 1042.72113ms
After changes: 941.3611ms

Number of elements on lab network (before / after setting data):
Before changes: 163 / 601
After changes: 114 / 534

BUG=549289
==========

[apacible, 2015-11-07 01:36:31]

Patchset #2 (id:60001) has been deleted

[apacible, 2015-11-07 01:41:41]

Patchset #2 (id:80001) has been deleted

[apacible, 2015-11-07 02:00:44]

Description was changed from

==========
[Media Router] Add conditional templating to media-router-header.

Adds conditional templating to media-router-header. Each header is not expected
to change views once it's initially set. Stamping unused elements is not
necessary. Wrapping it in conditional templating (dom-if) reduces the number of
elements on page load as well as the time it takes to initialize.

Time it takes from toolbar icon pressed to UI initialized (average 10 trials):
Before changes: 1042.72113ms
After changes: 941.3611ms

Number of elements on lab network (before / after setting data):
Before changes: 163 / 601
After changes: 114 / 534

BUG=549289
==========

to

==========
[Media Router] Use common media-router-header for MR UI.

Uses a common media-router-header for all of Media Router WebUI, which now lives
in media-router-container.

Time it takes from toolbar icon pressed to UI initialized (average 10 trials):
Before changes: 1031.492ms
After changes: 952.137ms

Number of elements on lab network (before / after setting data):
Before changes: 163 / 601
After changes: 121 / 523

BUG=549289
==========

[apacible, 2015-11-07 02:09:22]

On 2015/11/04 22:05:41, imcheng1 wrote:
> Discussed offline: the fact that we have multiple media-router-header across
> different elements (media-router-container, issue-banner, route-details) but
> that only at most one of them is shown at any given time suggests that there
is
> more room for optimization in the higher level, i.e., the media-router-header
> can be shared across multiple views. 
> 
> Right now we are actually stamping 2 media-router-header on startup due to the
> extra one in route-details. Sharing the header should in theory speed up since
> now we would have fewer elements to stamp and fewer computations related to
> media-router-header.

There were two things I previously added conditional templating for:
1. Back button icon
2. Arrow drop icon

I removed these changes and updated the CL to reflect that this change is only
for switching to using a common header across the entire UI.

With a common header, the arrow drop icon will always be stamped since the
Polymer elements will load before the UI is populated with any sinks/routes. The
back button icon is lightweight enough that I didn't find any noticeable
difference with load time when it is always stamped versus conditionally
stamped. I've also updated the load time and element counts to reflect the new
changes.

[imcheng, 2015-11-09 21:23:32]

lgtm % 2 comments

https://codereview.chromium.org/1415533019/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js
(right):

https://codereview.chromium.org/1415533019/diff/100001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js:15:
currentView_: {
Looks like this can be removed.

https://codereview.chromium.org/1415533019/diff/100001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/route_details/route_details.html
(right):

https://codereview.chromium.org/1415533019/diff/100001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/route_details/route_details.html:6:
<template>
Can |currentView_| and |sink| be removed from route_details.js?

[apacible, 2015-11-09 22:43:20]

https://codereview.chromium.org/1415533019/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js
(right):

https://codereview.chromium.org/1415533019/diff/100001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js:15:
currentView_: {
On 2015/11/09 21:23:32, imcheng1 wrote:
> Looks like this can be removed.

Done.

https://codereview.chromium.org/1415533019/diff/100001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/route_details/route_details.html
(right):

https://codereview.chromium.org/1415533019/diff/100001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/route_details/route_details.html:6:
<template>
On 2015/11/09 21:23:32, imcheng1 wrote:
> Can |currentView_| and |sink| be removed from route_details.js?

Done.

[imcheng, 2015-11-09 22:47:37]

https://codereview.chromium.org/1415533019/diff/120001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(right):

https://codereview.chromium.org/1415533019/diff/120001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:56:
sink="[[computeSinkForCurrentRoute_(currentRoute_)]]"
remove

https://codereview.chromium.org/1415533019/diff/120001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
(right):

https://codereview.chromium.org/1415533019/diff/120001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:428:
computeSinkForCurrentRoute_: function(route) {
remove

[apacible, 2015-11-09 22:57:35]

https://codereview.chromium.org/1415533019/diff/120001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(right):

https://codereview.chromium.org/1415533019/diff/120001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:56:
sink="[[computeSinkForCurrentRoute_(currentRoute_)]]"
On 2015/11/09 22:47:36, imcheng1 wrote:
> remove

Done.

https://codereview.chromium.org/1415533019/diff/120001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
(right):

https://codereview.chromium.org/1415533019/diff/120001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:428:
computeSinkForCurrentRoute_: function(route) {
On 2015/11/09 22:47:36, imcheng1 wrote:
> remove

Done.

[apacible, 2015-11-10 00:32:12]

The CQ bit was checked by apacible@chromium.org

[apacible, 2015-11-10 00:32:12]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1415533019/#ps140001
(title: "Changes per imcheng@'s comments.")

[commit-bot: I haz the power, 2015-11-10 00:36:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415533019/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415533019/140001

[commit-bot: I haz the power, 2015-11-10 01:28:35]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2015-11-10 01:29:29]

Patchset 4 (id:??) landed as
https://crrev.com/34b9c5e95141c667baaabb1b22c790b5797639af
Cr-Commit-Position: refs/heads/master@{#358731}