chrome/test/data/webui/media_router/issue_banner_tests.js - Issue 1415533019: [Media Router] Use common media-router-header for MR UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/media_router/issue_banner_tests.js

Issue 1415533019: [Media Router] Use common media-router-header for MR UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per imcheng@'s comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/media_router/elements/route_details/route_details.js ('k') | chrome/test/data/webui/media_router/media_router_container_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/media_router/issue_banner_tests.js

diff --git a/chrome/test/data/webui/media_router/issue_banner_tests.js b/chrome/test/data/webui/media_router/issue_banner_tests.js

index cbcc607be3456f69656a2d0508c5c12ed55d0be4..18295674663b0f52f2bd11aa3bc26064a80ff089 100644

--- a/chrome/test/data/webui/media_router/issue_banner_tests.js

+++ b/chrome/test/data/webui/media_router/issue_banner_tests.js

@@ -186,22 +186,18 @@ cr.define('issue_banner', function() {

// The blocking UI should be shown along with an optional action.

banner.issue = fakeBlockingIssueOne;

checkButtonVisibility(fakeBlockingIssueOne.secondaryActionType);

- assertFalse(banner.$['issue-header'].hasAttribute('hidden'));

// The blocking UI should be shown without an optional action.

banner.issue = fakeBlockingIssueTwo;

checkButtonVisibility(fakeBlockingIssueTwo.secondaryActionType);

- assertFalse(banner.$['issue-header'].hasAttribute('hidden'));

// The non-blocking UI should be shown along with an optional action.

banner.issue = fakeNonBlockingIssueOne;

checkButtonVisibility(fakeNonBlockingIssueOne.secondaryActionType);

- assertTrue(banner.$['issue-header'].hasAttribute('hidden'));

// The non-blocking UI should be shown without an optional action.

banner.issue = fakeNonBlockingIssueTwo;

checkButtonVisibility(fakeNonBlockingIssueTwo.secondaryActionType);

- assertTrue(banner.$['issue-header'].hasAttribute('hidden'));

});

}