chrome/test/data/webui/media_router/media_router_container_tests.js - Issue 1415533019: [Media Router] Use common media-router-header for MR UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/media_router/media_router_container_tests.js

Issue 1415533019: [Media Router] Use common media-router-header for MR UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per imcheng@'s comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/media_router/issue_banner_tests.js ('k') | chrome/test/data/webui/media_router/route_details_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/media_router/media_router_container_tests.js

diff --git a/chrome/test/data/webui/media_router/media_router_container_tests.js b/chrome/test/data/webui/media_router/media_router_container_tests.js

index 95d5089e33bd68d73c556c30faf1ba2ce341796b..e26af872484eeed1bf99fde49a8d5976e6c220c2 100644

--- a/chrome/test/data/webui/media_router/media_router_container_tests.js

+++ b/chrome/test/data/webui/media_router/media_router_container_tests.js

@@ -403,8 +403,7 @@ cr.define('media_router_container', function() {

// Set a blocking issue. The issue should stay hidden.

container.issue = fakeBlockingIssue;

- checkElementsVisibleWithId(['cast-mode-list',

- 'container-header',

+ checkElementsVisibleWithId(['container-header',

'device-missing',

'sink-list']);

});

@@ -413,7 +412,8 @@ cr.define('media_router_container', function() {

// Tests for expected visible UI when the view is ROUTE_DETAILS.

test('route details visibility', function() {

container.showRouteDetails_();

- checkElementsVisibleWithId(['device-missing',

+ checkElementsVisibleWithId(['container-header',

+ 'device-missing',

'route-details',

'sink-list']);

});

@@ -426,7 +426,8 @@ cr.define('media_router_container', function() {

// Set a non-blocking issue. The issue should be shown.

container.issue = fakeNonBlockingIssue;

setTimeout(function() {

- checkElementsVisibleWithId(['device-missing',

+ checkElementsVisibleWithId(['container-header',

+ 'device-missing',

'issue-banner',

'route-details',

'sink-list']);

@@ -443,7 +444,8 @@ cr.define('media_router_container', function() {

// else, hidden.

container.issue = fakeBlockingIssue;

setTimeout(function() {

- checkElementsVisibleWithId(['device-missing',

+ checkElementsVisibleWithId(['container-header',

+ 'device-missing',

'issue-banner',

'sink-list']);

done();

@@ -496,7 +498,9 @@ cr.define('media_router_container', function() {

// else, hidden.

container.issue = fakeBlockingIssue;

setTimeout(function() {

- checkElementsVisibleWithId(['issue-banner', 'sink-list']);

+ checkElementsVisibleWithId(['container-header',

+ 'issue-banner',

+ 'sink-list']);

done();

});