Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415463022: Use DiagnosticMessage in MockCompiler. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+623 lines, -554 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/analyze_all_test.dart View 1 chunk +17 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/diagnose_ambiguous_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/compiler/dart2js/diagnostic_helper.dart View 1 chunk +149 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/duplicate_library_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +1 line, -58 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 9 chunks +20 lines, -123 lines 0 comments Download
M tests/compiler/dart2js/override_inheritance_test.dart View 1 chunk +12 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/part_of_test.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 29 chunks +183 lines, -153 lines 0 comments Download
M tests/compiler/dart2js/private_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 29 chunks +143 lines, -115 lines 2 comments Download
M tests/compiler/dart2js/show_package_warnings_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 3 chunks +16 lines, -16 lines 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 3 chunks +5 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/type_variable_bound_test.dart View 5 chunks +52 lines, -38 lines 0 comments Download
M tests/compiler/dart2js/warnings_checker.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in mock_compiler.dart, diagnostic_helper.dart and memory_compiler.dart. DiagnosticCollector and DiagnosticMessage are moved from memory_compiler.dart to ...
5 years, 1 month ago (2015-11-09 15:30:09 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1415463022/diff/1/tests/compiler/dart2js/resolver_test.dart File tests/compiler/dart2js/resolver_test.dart (right): https://codereview.chromium.org/1415463022/diff/1/tests/compiler/dart2js/resolver_test.dart#newcode891 tests/compiler/dart2js/resolver_test.dart:891: MockCompiler.create((MockCompiler compiler) { Not for this CL, but ...
5 years, 1 month ago (2015-11-10 07:52:54 UTC) #3
Johnni Winther
https://codereview.chromium.org/1415463022/diff/1/tests/compiler/dart2js/resolver_test.dart File tests/compiler/dart2js/resolver_test.dart (right): https://codereview.chromium.org/1415463022/diff/1/tests/compiler/dart2js/resolver_test.dart#newcode891 tests/compiler/dart2js/resolver_test.dart:891: MockCompiler.create((MockCompiler compiler) { On 2015/11/10 07:52:54, sigurdm wrote: > ...
5 years, 1 month ago (2015-11-10 09:38:52 UTC) #4
Johnni Winther
5 years, 1 month ago (2015-11-10 10:13:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0133786ae0c7a38822256e6ec127672d6315938c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698