Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: tests/compiler/dart2js/memory_compiler.dart

Issue 1415463022: Use DiagnosticMessage in MockCompiler. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/memory_compiler.dart
diff --git a/tests/compiler/dart2js/memory_compiler.dart b/tests/compiler/dart2js/memory_compiler.dart
index 0de4d37a334674d8fb3323651a3933eed5856c22..8d788f6562f7da3b8010dfe84e3c30a5bce5f023 100644
--- a/tests/compiler/dart2js/memory_compiler.dart
+++ b/tests/compiler/dart2js/memory_compiler.dart
@@ -28,64 +28,7 @@ import 'memory_source_file_helper.dart';
export 'output_collector.dart';
export 'package:compiler/compiler_new.dart' show
CompilationResult;
-
-class DiagnosticMessage {
- final Message message;
- final Uri uri;
- final int begin;
- final int end;
- final String text;
- final Diagnostic kind;
-
- DiagnosticMessage(
- this.message, this.uri, this.begin, this.end, this.text, this.kind);
-
- String toString() => '$uri:$begin:$end:$text:$kind';
-}
-
-class DiagnosticCollector implements CompilerDiagnostics {
- List<DiagnosticMessage> messages = <DiagnosticMessage>[];
-
- void call(Uri uri, int begin, int end, String message, Diagnostic kind) {
- report(null, uri, begin, end, message, kind);
- }
-
- @override
- void report(Message message,
- Uri uri, int begin, int end, String text, Diagnostic kind) {
- messages.add(new DiagnosticMessage(message, uri, begin, end, text, kind));
- }
-
- Iterable<DiagnosticMessage> filterMessagesByKinds(List<Diagnostic> kinds) {
- return messages.where(
- (DiagnosticMessage message) => kinds.contains(message.kind));
- }
-
- Iterable<DiagnosticMessage> get errors {
- return filterMessagesByKinds([Diagnostic.ERROR]);
- }
-
- Iterable<DiagnosticMessage> get warnings {
- return filterMessagesByKinds([Diagnostic.WARNING]);
- }
-
- Iterable<DiagnosticMessage> get hints {
- return filterMessagesByKinds([Diagnostic.HINT]);
- }
-
- Iterable<DiagnosticMessage> get infos {
- return filterMessagesByKinds([Diagnostic.INFO]);
- }
-
- /// `true` if non-verbose messages has been collected.
- bool get hasRegularMessages {
- return messages.any((m) => m.kind != Diagnostic.VERBOSE_INFO);
- }
-
- void clear() {
- messages.clear();
- }
-}
+export 'diagnostic_helper.dart';
class MultiDiagnostics implements CompilerDiagnostics {
final List<CompilerDiagnostics> diagnosticsList;

Powered by Google App Engine
This is Rietveld 408576698