pkg/compiler/lib/src/apiimpl.dart - Issue 1415463022: Use DiagnosticMessage in MockCompiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/apiimpl.dart

Issue 1415463022: Use DiagnosticMessage in MockCompiler. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/apiimpl.dart

diff --git a/pkg/compiler/lib/src/apiimpl.dart b/pkg/compiler/lib/src/apiimpl.dart

index 33f2e7f9dc01a49a15aa4e8585adf97d4d7955d2..3bd085f8f927f0f4da93ba1bd3c8e1af3b8db10a 100644

--- a/pkg/compiler/lib/src/apiimpl.dart

+++ b/pkg/compiler/lib/src/apiimpl.dart

@@ -499,13 +499,6 @@ class CompilerImpl extends Compiler {

void reportDiagnostic(DiagnosticMessage message,

List<DiagnosticMessage> infos,

api.Diagnostic kind) {

- // TODO(johnniwinther): Move this to the [DiagnosticReporter]?

- if (kind == api.Diagnostic.ERROR ||

- kind == api.Diagnostic.CRASH ||

- (reporter.options.fatalWarnings &&

- kind == api.Diagnostic.WARNING)) {

- compilationFailed = true;

- }

_reportDiagnosticMessage(message, kind);

for (DiagnosticMessage info in infos) {

_reportDiagnosticMessage(info, api.Diagnostic.INFO);