Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2890)

Unified Diff: chrome/browser/resources/options/password_manager_list.js

Issue 1415333009: [Password Manager] Recovers implied focus traverse on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_550270
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/password_manager_list.js
diff --git a/chrome/browser/resources/options/password_manager_list.js b/chrome/browser/resources/options/password_manager_list.js
index 85cf0aef2165c58d6e13861d57fa6e599bc71f5a..b6c869aae48ff4e50deca29d4ae269fa8d769fcd 100644
--- a/chrome/browser/resources/options/password_manager_list.js
+++ b/chrome/browser/resources/options/password_manager_list.js
@@ -81,6 +81,7 @@ cr.define('options.passwordManager', function() {
urlDiv.style.backgroundImage = getFaviconImageSet(
'origin/' + this.url, 16);
this.contentElement.appendChild(urlDiv);
+ this.urlLink = urlLink;
// The stored username.
var usernameDiv = this.ownerDocument.createElement('div');
@@ -173,7 +174,10 @@ cr.define('options.passwordManager', function() {
*/
setFocusable_: function(focusable) {
var tabIndex = focusable ? 0 : -1;
- this.passwordField.tabIndex = this.closeButtonElement.tabIndex = tabIndex;
+ this.urlLink.tabIndex = tabIndex;
+ this.usernameField.tabIndex = tabIndex;
+ this.passwordField.tabIndex = tabIndex;
+ this.closeButtonElement.tabIndex = tabIndex;
},
/**
@@ -328,6 +332,7 @@ cr.define('options.passwordManager', function() {
urlDiv.appendChild(urlLink);
urlDiv.style.backgroundImage = getFaviconImageSet(
'origin/' + this.url, 16);
+ urlLink.tabIndex = -1;
this.contentElement.appendChild(urlDiv);
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698