Avoid image resource leaks in frame-related unit tests.

Avoid image resource leaks in frame-related unit tests.

When ImageLoader issues a (successful) load, it will keep its associated
element alive until the load has finished, so as to guarantee that the
load will complete without DOM mutations destructing the element.

This keep-alive reference is at odds with tidy shutdowns from unit tests
that issue image resource loads in particular, as they will not have
completed upon shutdown if the load hasn't otherwise been triggered.
By default they won't be, eaving the associated element and its
ImageLoader referred-to resources as reportedly leaking.

To avoid such leaks, insist that image resources are eagerly loaded
from the network by WebViewHelpers, if needs be. Which means that all such
external resources are mocked & accounted for.

R=haraken, thakis
BUG=526423
Committed: https://crrev.com/fc199ea30c9558abb49215948fd6aa3936764c7c
Cr-Commit-Position: refs/heads/master@{#355318}

[sof, 2015-10-21 09:25:50]

sigbjornf@opera.com changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org, thakis@chromium.org

[sof, 2015-10-21 09:25:51]

please take a look.

This takes care of the remaining LeakSanitizer-reported leaks. The downside
being that unit tests now will have to mock image URLs.

[haraken, 2015-10-21 13:49:20]

LGTM

[sof, 2015-10-21 15:12:01]

Description was changed from

==========
Avoid image resource leaks in frame-related unit tests.

When ImageLoader issues a (successful) load, it will keep its associated
element alive until the load has finished, so as to guarantee that the
load will complete without DOM mutations destructing the element.

This keep-alive reference is at odds with tidy shutdowns from unit tests
that issue image resource loads in particular, as they will not have
completed upon shutdown if the load hasn't otherwise been triggered.
By default they won't be, eaving the associated element and its
ImageLoader referred-to resources as reportedly leaking.

To avoid such leaks, insist that image resources are eagerly loaded
from the network by WebViewHelpers, if needs be. Which means that all such
external resources are mocked & accounted for.

R=
BUG=526423
==========

to

==========
Avoid image resource leaks in frame-related unit tests.

When ImageLoader issues a (successful) load, it will keep its associated
element alive until the load has finished, so as to guarantee that the
load will complete without DOM mutations destructing the element.

This keep-alive reference is at odds with tidy shutdowns from unit tests
that issue image resource loads in particular, as they will not have
completed upon shutdown if the load hasn't otherwise been triggered.
By default they won't be, eaving the associated element and its
ImageLoader referred-to resources as reportedly leaking.

To avoid such leaks, insist that image resources are eagerly loaded
from the network by WebViewHelpers, if needs be. Which means that all such
external resources are mocked & accounted for.

R=haraken
BUG=526423
==========

[Nico, 2015-10-21 16:28:00]

lgtm, thanks!

[sof, 2015-10-21 16:39:13]

Description was changed from

==========
Avoid image resource leaks in frame-related unit tests.

When ImageLoader issues a (successful) load, it will keep its associated
element alive until the load has finished, so as to guarantee that the
load will complete without DOM mutations destructing the element.

This keep-alive reference is at odds with tidy shutdowns from unit tests
that issue image resource loads in particular, as they will not have
completed upon shutdown if the load hasn't otherwise been triggered.
By default they won't be, eaving the associated element and its
ImageLoader referred-to resources as reportedly leaking.

To avoid such leaks, insist that image resources are eagerly loaded
from the network by WebViewHelpers, if needs be. Which means that all such
external resources are mocked & accounted for.

R=haraken
BUG=526423
==========

to

==========
Avoid image resource leaks in frame-related unit tests.

When ImageLoader issues a (successful) load, it will keep its associated
element alive until the load has finished, so as to guarantee that the
load will complete without DOM mutations destructing the element.

This keep-alive reference is at odds with tidy shutdowns from unit tests
that issue image resource loads in particular, as they will not have
completed upon shutdown if the load hasn't otherwise been triggered.
By default they won't be, eaving the associated element and its
ImageLoader referred-to resources as reportedly leaking.

To avoid such leaks, insist that image resources are eagerly loaded
from the network by WebViewHelpers, if needs be. Which means that all such
external resources are mocked & accounted for.

R=haraken, thakis
BUG=526423
==========

[dcheng, 2015-10-21 16:39:18]

lgtm

Devs will see errors at unit test run time if they forget to mock out the image
load, right?

[sof, 2015-10-21 16:39:25]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-10-21 16:39:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415123002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415123002/20001

[sof, 2015-10-21 17:12:44]

On 2015/10/21 16:39:18, dcheng wrote:
> lgtm
> 
> Devs will see errors at unit test run time if they forget to mock out the
image
> load, right?

Yes, DCHECK() triggers in the weburl mock loader.

[commit-bot: I haz the power, 2015-10-21 17:16:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-21 17:17:49]

Patchset 2 (id:??) landed as
https://crrev.com/fc199ea30c9558abb49215948fd6aa3936764c7c
Cr-Commit-Position: refs/heads/master@{#355318}