Avoid image resource leaks in frame-related unit tests.

third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 50 matching lines @@
         m_string += data;
     }
 
     std::string m_string;
 };
 
 } // namespace
 
 class WebPageSerializerTest : public testing::Test {
 public:
-    WebPageSerializerTest() : m_supportedSchemes(static_cast<size_t>(3))
+    WebPageSerializerTest()
+        : m_supportedSchemes(static_cast<size_t>(3))
     {
         m_supportedSchemes[0] = "http";
         m_supportedSchemes[1] = "https";
         m_supportedSchemes[2] = "file";
+
+        registerMockedImageURL("http://www.test.com/awesome.png");
     }
 
 protected:
     void SetUp() override
     {
         m_helper.initialize();
     }
 
     void TearDown() override
     {
         Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
     }
 
     void registerMockedURLLoad(const std::string& url, const WebString& fileName)
     {
         URLTestHelpers::registerMockedURLLoad(toKURL(url), fileName, WebString::fromUTF8("pageserialization/"), WebString::fromUTF8("text/html"));
     }
 
+    void registerMockedImageURL(const std::string& url)
+    {
+        // Image resources need to be mocked, but irrelevant here what image they map to.
+        URLTestHelpers::registerMockedURLLoad(toKURL(url), "pageserialization/awesome.png");
+    }
+
     void loadURLInTopFrame(const WebURL& url)
     {
         FrameTestHelpers::loadFrame(m_helper.webView()->mainFrame(), url.string().utf8());
     }
 
     static bool webVectorContains(const WebVector<WebURL>& vector, const char* url)
     {
         return vector.contains(WebURL(toKURL(std::string(url))));
     }
 
@@ skipping 11 matching lines @@
 private:
     FrameTestHelpers::WebViewHelper m_helper;
 };
 
 TEST_F(WebPageSerializerTest, HTMLNodes)
 {
     // Register the mocked frame and load it.
     WebURL topFrameURL = toKURL("http://www.test.com");
     registerMockedURLLoad("http://www.test.com", WebString::fromUTF8("simple_page.html"));
     registerMockedURLLoad("http://www.example.com/beautifull.css", WebString::fromUTF8("beautifull.css"));
+
+    registerMockedImageURL("http://www.test.com/imageButton.png");
+    registerMockedImageURL("http://www.test.com/tableBackground.png");
+    registerMockedImageURL("http://www.test.com/trBackground.png");
+    registerMockedImageURL("http://www.test.com/tdBackground.png");
+    registerMockedImageURL("http://www.test.com/innerFrame.png");
+    registerMockedImageURL("http://www.test.com/bodyBackground.jpg");
+    registerMockedImageURL("https://www.secure.com/https.gif");
+    registerMockedImageURL("ftp://ftp.com/ftp.gif");
+    registerMockedImageURL("unknown://unkown.com/unknown.gif");
+
     loadURLInTopFrame(topFrameURL);
 
     // Retrieve all resources.
     WebVector<WebURL> frames;
     WebVector<WebURL> resources;
     ASSERT_TRUE(WebPageSerializer::retrieveAllResources(
         webView(), m_supportedSchemes, &resources, &frames));
 
     // Tests that all resources from the frame have been retrieved.
     EXPECT_EQ(1U, frames.size()); // There should be no duplicates.
@@ skipping 13 matching lines @@
     EXPECT_TRUE(webVectorContains(resources, "http://www.test.com/why_deleted.html"));
     EXPECT_TRUE(webVectorContains(resources, "http://www.test.com/why_inserted.html"));
     EXPECT_TRUE(webVectorContains(resources, "https://www.secure.com/https.gif"));
     EXPECT_TRUE(webVectorContains(resources, "file://c/my_folder/file.gif"));
 }
 
 TEST_F(WebPageSerializerTest, URLAttributeValues)
 {
     WebURL topFrameURL = toKURL("http://www.test.com");
     registerMockedURLLoad(topFrameURL.spec(), WebString::fromUTF8("url_attribute_values.html"));
+    registerMockedImageURL("javascript:\"");
+
     loadURLInTopFrame(topFrameURL);
 
     SimpleWebPageSerializerClient serializerClient;
     WebVector<WebURL> links(&topFrameURL, 1);
     WebVector<WebString> localPaths(&"local", 1);
     WebPageSerializer::serialize(webView()->mainFrame()->toWebLocalFrame(), &serializerClient, links, localPaths, "");
 
     const char* expectedHTML =
         "\n<!-- saved from url=(0020)http://www.test.com/ -->\n"
         "<html><head><meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"><meta charset=\"utf8\">\n"
@@ skipping 22 matching lines @@
 {
     // Register the mocked frames.
     WebURL topFrameURL = toKURL("http://www.test.com");
     registerMockedURLLoad("http://www.test.com", WebString::fromUTF8("top_frame.html"));
     registerMockedURLLoad("http://www.test.com/simple_iframe.html",
                           WebString::fromUTF8("simple_iframe.html"));
     registerMockedURLLoad("http://www.test.com/object_iframe.html",
                           WebString::fromUTF8("object_iframe.html"));
     registerMockedURLLoad("http://www.test.com/embed_iframe.html",
                           WebString::fromUTF8("embed_iframe.html"));
-    // If we don't register a mocked resource for awesome.png, it causes the
-    // document loader of the iframe that has it as its src to assert on close,
-    // not sure why.
-    registerMockedURLLoad("http://www.test.com/awesome.png",
-                          WebString::fromUTF8("awesome.png"));
+    registerMockedImageURL("http://www.test.com/innerFrame.png");
+    registerMockedImageURL("http://www.test.com/embed.png");
+    registerMockedImageURL("http://www.test.com/object.png");
 
     loadURLInTopFrame(topFrameURL);
 
     // Retrieve all resources.
     WebVector<WebURL> frames;
     WebVector<WebURL> resources;
     ASSERT_TRUE(WebPageSerializer::retrieveAllResources(
         webView(), m_supportedSchemes, &resources, &frames));
 
     // Tests that all resources from the frame have been retrieved.
     EXPECT_EQ(4U, frames.size()); // There should be no duplicates.
     EXPECT_TRUE(webVectorContains(frames, "http://www.test.com"));
     EXPECT_TRUE(webVectorContains(frames, "http://www.test.com/simple_iframe.html"));
     EXPECT_TRUE(webVectorContains(frames, "http://www.test.com/object_iframe.html"));
     EXPECT_TRUE(webVectorContains(frames, "http://www.test.com/embed_iframe.html"));
 
     EXPECT_EQ(5U, resources.size()); // There should be no duplicates.
     EXPECT_TRUE(webVectorContains(resources, "http://www.test.com/awesome.png"));
     EXPECT_TRUE(webVectorContains(resources, "http://www.test.com/innerFrame.png"));
     EXPECT_TRUE(webVectorContains(resources, "http://www.test.com/flash.swf"));
     // FIXME: for some reason the following resources is missing on one of the bot
     //        causing the test to fail. Probably a plugin issue.
     // EXPECT_TRUE(webVectorContains(resources, "http://www.test.com/music.mid"));
     EXPECT_TRUE(webVectorContains(resources, "http://www.test.com/object.png"));
     EXPECT_TRUE(webVectorContains(resources, "http://www.test.com/embed.png"));
 }
 
 } // namespace blink