Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1415123002: Avoid image resource leaks in frame-related unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove redundant #include Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index a36d23449f195f904db8771cb9c6624b9381cc17..c428e46d048596d33895b81287312380986cd802 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -252,6 +252,7 @@ TEST_F(WebViewTest, SaveImageAt)
std::string url = m_baseURL + "image-with-data-url.html";
URLTestHelpers::registerMockedURLLoad(toKURL(url), "image-with-data-url.html");
+ URLTestHelpers::registerMockedURLLoad(toKURL("http://test"), "white-1x1.png");
WebViewImpl* webView = m_webViewHelper.initializeAndLoad(url, true, 0, &client);
webView->resize(WebSize(400, 400));
webView->layout();
@@ -883,6 +884,7 @@ TEST_F(WebViewTest, TextInputInfoWithReplacedElements)
{
std::string url = m_baseURL + "div_with_image.html";
URLTestHelpers::registerMockedURLLoad(toKURL(url), "div_with_image.html");
+ URLTestHelpers::registerMockedURLLoad(toKURL("http://www.test.com/foo.png"), "white-1x1.png");
WebView* webView = m_webViewHelper.initializeAndLoad(url);
webView->setInitialFocus(false);
WebTextInputInfo info = webView->textInputInfo();
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698