Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1414943003: Moves move logic into WM instead of WS (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves move logic into WM instead of WS The WS still needs to know about client area, which feels a bit unfortunate. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/d4ca12f08e8ad8c98ad4051e88a183b368cc5938 Cr-Commit-Position: refs/heads/master@{#356586}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix build #

Patch Set 3 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -439 lines) Patch
M components/mus/example/wm/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
A + components/mus/example/wm/move_loop.h View 4 chunks +15 lines, -27 lines 0 comments Download
A + components/mus/example/wm/move_loop.cc View 5 chunks +18 lines, -25 lines 0 comments Download
M components/mus/example/wm/window_manager_application.h View 3 chunks +5 lines, -0 lines 0 comments Download
M components/mus/example/wm/window_manager_application.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M components/mus/example/wm/window_manager_impl.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M components/mus/example/wm/window_manager_impl.cc View 3 chunks +37 lines, -1 line 0 comments Download
M components/mus/public/interfaces/window_tree_host.mojom View 1 chunk +0 lines, -6 lines 0 comments Download
M components/mus/ws/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/mus/ws/event_dispatcher.h View 2 chunks +4 lines, -11 lines 0 comments Download
M components/mus/ws/event_dispatcher.cc View 1 6 chunks +34 lines, -42 lines 0 comments Download
M components/mus/ws/event_dispatcher_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/mus/ws/event_dispatcher_unittest.cc View 9 chunks +25 lines, -68 lines 0 comments Download
D components/mus/ws/move_loop.h View 1 chunk +0 lines, -89 lines 0 comments Download
D components/mus/ws/move_loop.cc View 1 chunk +0 lines, -142 lines 0 comments Download
M components/mus/ws/server_window.h View 2 chunks +0 lines, -9 lines 0 comments Download
M components/mus/ws/server_window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 2 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sky
5 years, 1 month ago (2015-10-28 15:27:35 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/1414943003/diff/1/components/mus/example/wm/window_manager_impl.cc File components/mus/example/wm/window_manager_impl.cc (right): https://codereview.chromium.org/1414943003/diff/1/components/mus/example/wm/window_manager_impl.cc#newcode57 components/mus/example/wm/window_manager_impl.cc:57: child_window->AddObserver(this); can be changed later (since it'll likely ...
5 years, 1 month ago (2015-10-28 16:03:16 UTC) #2
sky
https://codereview.chromium.org/1414943003/diff/1/components/mus/example/wm/window_manager_impl.cc File components/mus/example/wm/window_manager_impl.cc (right): https://codereview.chromium.org/1414943003/diff/1/components/mus/example/wm/window_manager_impl.cc#newcode57 components/mus/example/wm/window_manager_impl.cc:57: child_window->AddObserver(this); On 2015/10/28 16:03:16, Ben Goodger (Google) wrote: > ...
5 years, 1 month ago (2015-10-28 16:17:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414943003/20001
5 years, 1 month ago (2015-10-28 16:18:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/132592)
5 years, 1 month ago (2015-10-28 16:45:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414943003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414943003/40001
5 years, 1 month ago (2015-10-28 17:03:12 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-28 18:22:36 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 18:23:58 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d4ca12f08e8ad8c98ad4051e88a183b368cc5938
Cr-Commit-Position: refs/heads/master@{#356586}

Powered by Google App Engine
This is Rietveld 408576698