[Reland] Properly escape node names in DependencyGraph Graphviz export

[Reland] Properly escape node names in DependencyGraph Graphviz export

This is a reland of https://codereview.chromium.org/1414053004/.
Patch set 1 here is the reverted one (patch from issue 1414053004 at patchset 80001 (http://crrev.com/1414053004#ps80001), reverted in https://codereview.chromium.org/1419843006/).
The following patch set fixes the Win 64bit error, due to which it got reverted.

R=erg@chromium.org,tfarina@chromium.org

tfarina@ approved this adding re2 to components/keyed_service/core/DEPS in https://codereview.chromium.org/1414053004#msg7 (that part was not changed for relanding).
TBR=tfarina@chromium.org

BUG=546954
Committed: https://crrev.com/98afb1456eff620ee036f4cf1f120cff5bdb3828
Cr-Commit-Position: refs/heads/master@{#356583}

[vabr (Chromium), 2015-10-28 16:27:16]

Elliot,
Please review the diff of patch set 2 against 1 (this:
https://codereview.chromium.org/1414843004/diff2/1:20001/components/keyed_ser...).

No input needed from tfarina@, the reland did not change the dependencies since
the previous approved CL.

I was able to reproduce the build failure on the bot win_chromium_gn_x64_rel --
failing on patch set 1, fixed in p.s. 2.

Cheers,
Vaclav

[Elliot Glaysher, 2015-10-28 17:11:35]

lgtm

[vabr (Chromium), 2015-10-28 17:37:49]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2015-10-28 17:38:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414843004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414843004/20001

[commit-bot: I haz the power, 2015-10-28 17:47:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 17:47:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2015-10-28 17:56:26]

Description was changed from

==========
[Reland] Properly escape node names in DependencyGraph Graphviz export

This is a reland of https://codereview.chromium.org/1414053004/.
Patch set 1 here is the reverted one (patch from issue 1414053004 at patchset
80001 (http://crrev.com/1414053004#ps80001), reverted in
https://codereview.chromium.org/1419843006/).
The following patch set fixes the Win 64bit error, due to which it got reverted.

R=erg@chromium.org,tfarina@chromium.org
BUG=546954
==========

to

==========
[Reland] Properly escape node names in DependencyGraph Graphviz export

This is a reland of https://codereview.chromium.org/1414053004/.
Patch set 1 here is the reverted one (patch from issue 1414053004 at patchset
80001 (http://crrev.com/1414053004#ps80001), reverted in
https://codereview.chromium.org/1419843006/).
The following patch set fixes the Win 64bit error, due to which it got reverted.

R=erg@chromium.org,tfarina@chromium.org

tfarina@ approved this adding re2 to components/keyed_service/core/DEPS in
https://codereview.chromium.org/1414053004#msg7 (that part was not changed for
relanding).
TBR=tfarina@chromium.org

BUG=546954
==========

[vabr (Chromium), 2015-10-28 17:56:34]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2015-10-28 17:56:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414843004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414843004/20001

[commit-bot: I haz the power, 2015-10-28 18:20:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-28 18:21:37]

Patchset 2 (id:??) landed as
https://crrev.com/98afb1456eff620ee036f4cf1f120cff5bdb3828
Cr-Commit-Position: refs/heads/master@{#356583}