Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414053004: Properly escape node names in DependencyGraph Graphviz export (Closed)

Created:
5 years, 2 months ago by vabr (Chromium)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly escape node names in DependencyGraph Graphviz export BUG=546954 Committed: https://crrev.com/6918fc7520a841b427e97f45f2f250480b93556b Cr-Commit-Position: refs/heads/master@{#356255}

Patch Set 1 : Test only, should fail #

Patch Set 2 : More tests #

Patch Set 3 : Fix #

Patch Set 4 : Re-upload to fix --similarity #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -5 lines) Patch
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/keyed_service/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/keyed_service/core/DEPS View 1 2 3 1 chunk +4 lines, -0 lines 1 comment Download
M components/keyed_service/core/dependency_graph.cc View 1 2 4 chunks +32 lines, -5 lines 0 comments Download
M components/keyed_service/core/dependency_graph_unittest.cc View 1 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
vabr (Chromium)
Hello! erg@ -- please review the whole CL. tfarina@ -- please review adding third_party/re2 to ...
5 years, 2 months ago (2015-10-23 18:39:22 UTC) #4
Elliot Glaysher
lgtm
5 years, 2 months ago (2015-10-23 19:12:17 UTC) #5
vabr (Chromium)
(Thanks Elliot!) tfarina@ -- please review adding third_party/re2 to components/keyed_service/core/DEPS Cheers, Vaclav
5 years, 1 month ago (2015-10-26 09:02:17 UTC) #6
tfarina
https://codereview.chromium.org/1414053004/diff/80001/components/keyed_service/core/DEPS File components/keyed_service/core/DEPS (right): https://codereview.chromium.org/1414053004/diff/80001/components/keyed_service/core/DEPS#newcode3 components/keyed_service/core/DEPS:3: "+third_party/re2", OK. LGTM
5 years, 1 month ago (2015-10-26 21:44:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414053004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414053004/80001
5 years, 1 month ago (2015-10-27 07:43:21 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 1 month ago (2015-10-27 09:08:39 UTC) #10
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/6918fc7520a841b427e97f45f2f250480b93556b Cr-Commit-Position: refs/heads/master@{#356255}
5 years, 1 month ago (2015-10-27 09:09:38 UTC) #11
dcaiafa
5 years, 1 month ago (2015-10-27 18:47:00 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/1419843006/ by dcaiafa@chromium.org.

The reason for reverting is: Broke win 64 builds:

e:\b\build\slave\win_x64_gn__dbg_\build\src\components\keyed_service\core\dependency_graph_unittest.cc(175)
: error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\keyed_service\core\dependency_graph_unittest.cc(175)
: warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss
of data
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\keyed_service\core\dependency_graph_unittest.cc(184)
: warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss
of data

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/...
.

Powered by Google App Engine
This is Rietveld 408576698