Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1419843006: Revert of Properly escape node names in DependencyGraph Graphviz export (Closed)

Created:
5 years, 1 month ago by dcaiafa
Modified:
5 years, 1 month ago
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Properly escape node names in DependencyGraph Graphviz export (patchset #4 id:80001 of https://codereview.chromium.org/1414053004/ ) Reason for revert: Broke win 64 builds: e:\b\build\slave\win_x64_gn__dbg_\build\src\components\keyed_service\core\dependency_graph_unittest.cc(175) : error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win_x64_gn__dbg_\build\src\components\keyed_service\core\dependency_graph_unittest.cc(175) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data e:\b\build\slave\win_x64_gn__dbg_\build\src\components\keyed_service\core\dependency_graph_unittest.cc(184) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/12333 Original issue's description: > Properly escape node names in DependencyGraph Graphviz export > > BUG=546954 > > Committed: https://crrev.com/6918fc7520a841b427e97f45f2f250480b93556b > Cr-Commit-Position: refs/heads/master@{#356255} TBR=erg@chromium.org,tfarina@chromium.org,vabr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546954 Committed: https://crrev.com/943cfb5e8fb4d9237f202ddf1843e27828c1d72a Cr-Commit-Position: refs/heads/master@{#356355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -92 lines) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/keyed_service/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/keyed_service/core/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M components/keyed_service/core/dependency_graph.cc View 4 chunks +5 lines, -32 lines 0 comments Download
M components/keyed_service/core/dependency_graph_unittest.cc View 2 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcaiafa
Created Revert of Properly escape node names in DependencyGraph Graphviz export
5 years, 1 month ago (2015-10-27 18:47:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419843006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419843006/1
5 years, 1 month ago (2015-10-27 18:47:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 18:49:37 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/943cfb5e8fb4d9237f202ddf1843e27828c1d72a Cr-Commit-Position: refs/heads/master@{#356355}
5 years, 1 month ago (2015-10-27 18:50:31 UTC) #4
vabr (Chromium)
5 years, 1 month ago (2015-10-28 11:09:10 UTC) #5
Message was sent while issue was closed.
On 2015/10/27 18:50:31, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/943cfb5e8fb4d9237f202ddf1843e27828c1d72a
> Cr-Commit-Position: refs/heads/master@{#356355}

Thanks for the revert, LGTM.

Powered by Google App Engine
This is Rietveld 408576698