Issue 1414793016: Merge to XFA: Cleanup: Remove some NULL checks in fpdfsdk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1414793016: Merge to XFA: Cleanup: Remove some NULL checks in fpdfsdk. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Oliver Chang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Cleanup: Remove some NULL checks in fpdfsdk. And simplify code. TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1411663013 . (cherry picked from commit ff5adbc0dfa71270a9979f0c3e1d27923c16218a) Committed: https://pdfium.googlesource.com/pdfium/+/997de6127fe4dd0f6df3ca72676e31311c3d66bd

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -50 lines)			Patch
M	fpdfsdk/src/formfiller/FFL_IFormFiller.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fpdfeditpage.cpp	View	3 chunks	+13 lines, -29 lines	0 comments	Download
M	fpdfsdk/src/fsdk_baseform.cpp	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	fpdfsdk/src/javascript/PublicMethods.cpp	View	2 chunks	+11 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

Committed patchset #1 (id:1) manually as 997de6127fe4dd0f6df3ca72676e31311c3d66bd (presubmit successful).

5 years, 1 month ago (2015-11-05 02:18:00 UTC) #2

Message was sent while issue was closed.

lgtm