Merge to XFA: Cleanup: Remove some NULL checks in fpdfsdk.

fpdfsdk/src/fsdk_baseform.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../third_party/base/nonstd_unique_ptr.h"
 #include "../include/fsdk_define.h"
 #include "../include/fpdfxfa/fpdfxfa_doc.h"
 #include "../include/fpdfxfa/fpdfxfa_util.h"
@@ skipping 2441 matching lines @@
     if (pFormField->CountSelectedItems() > 0) {
       int index = pFormField->GetSelectedIndex(0);
       if (index >= 0)
         sValue = pFormField->GetOptionLabel(index);
     }
   }
 
   bFormated = FALSE;
 
   CPDF_AAction aAction = pFormField->GetAdditionalAction();
-  if (aAction != NULL && aAction.ActionExist(CPDF_AAction::Format)) {
+  if (aAction && aAction.ActionExist(CPDF_AAction::Format)) {
     CPDF_Action action = aAction.GetAction(CPDF_AAction::Format);
     if (action) {
       CFX_WideString script = action.GetJavaScript();
       if (!script.IsEmpty()) {
         CFX_WideString Value = sValue;
 
         IJS_Context* pContext = pRuntime->NewContext();
         ASSERT(pContext != NULL);
 
         pContext->OnField_Format(pFormField, Value, TRUE);
@@ skipping 49 matching lines @@
     }
   }
 }
 
 void CPDFSDK_InterForm::OnKeyStrokeCommit(CPDF_FormField* pFormField,
                                           CFX_WideString& csValue,
                                           FX_BOOL& bRC) {
   ASSERT(pFormField != NULL);
 
   CPDF_AAction aAction = pFormField->GetAdditionalAction();
-  if (aAction != NULL && aAction.ActionExist(CPDF_AAction::KeyStroke)) {
+  if (aAction && aAction.ActionExist(CPDF_AAction::KeyStroke)) {
     CPDF_Action action = aAction.GetAction(CPDF_AAction::KeyStroke);
     if (action) {
       ASSERT(m_pDocument != NULL);
       CPDFDoc_Environment* pEnv = m_pDocument->GetEnv();
       ASSERT(pEnv != NULL);
 
       CPDFSDK_ActionHandler* pActionHandler = pEnv->GetActionHander();
       ASSERT(pActionHandler != NULL);
 
       PDFSDK_FieldAction fa;
       fa.bModifier = pEnv->FFI_IsCTRLKeyDown(0);
       fa.bShift = pEnv->FFI_IsSHIFTKeyDown(0);
       fa.sValue = csValue;
 
       pActionHandler->DoAction_FieldJavaScript(action, CPDF_AAction::KeyStroke,
                                                m_pDocument, pFormField, fa);
       bRC = fa.bRC;
     }
   }
 }
 
 void CPDFSDK_InterForm::OnValidate(CPDF_FormField* pFormField,
                                    CFX_WideString& csValue,
                                    FX_BOOL& bRC) {
   ASSERT(pFormField != NULL);
 
   CPDF_AAction aAction = pFormField->GetAdditionalAction();
-  if (aAction != NULL && aAction.ActionExist(CPDF_AAction::Validate)) {
+  if (aAction && aAction.ActionExist(CPDF_AAction::Validate)) {
     CPDF_Action action = aAction.GetAction(CPDF_AAction::Validate);
     if (action) {
       ASSERT(m_pDocument != NULL);
       CPDFDoc_Environment* pEnv = m_pDocument->GetEnv();
       ASSERT(pEnv != NULL);
 
       CPDFSDK_ActionHandler* pActionHandler = pEnv->GetActionHander();
       ASSERT(pActionHandler != NULL);
 
       PDFSDK_FieldAction fa;
@@ skipping 113 matching lines @@
 FX_BOOL CPDFSDK_InterForm::FDFToURLEncodedData(CFX_WideString csFDFFile,
                                                CFX_WideString csTxtFile) {
   return TRUE;
 }
 
 FX_BOOL CPDFSDK_InterForm::FDFToURLEncodedData(uint8_t*& pBuf,
                                                FX_STRSIZE& nBufSize) {
   CFDF_Document* pFDF = CFDF_Document::ParseMemory(pBuf, nBufSize);
   if (pFDF) {
     CPDF_Dictionary* pMainDict = pFDF->GetRoot()->GetDict("FDF");
-    if (pMainDict == NULL)
+    if (!pMainDict)
       return FALSE;
 
     // Get fields
     CPDF_Array* pFields = pMainDict->GetArray("Fields");
-    if (pFields == NULL)
+    if (!pFields)
       return FALSE;
 
     CFX_ByteTextBuf fdfEncodedData;
 
     for (FX_DWORD i = 0; i < pFields->GetCount(); i++) {
       CPDF_Dictionary* pField = pFields->GetDict(i);
-      if (pField == NULL)
+      if (!pField)
         continue;
       CFX_WideString name;
       name = pField->GetUnicodeText("T");
       CFX_ByteString name_b = CFX_ByteString::FromUnicode(name);
       CFX_ByteString csBValue = pField->GetString("V");
       CFX_WideString csWValue = PDF_DecodeText(csBValue);
       CFX_ByteString csValue_b = CFX_ByteString::FromUnicode(csWValue);
 
       fdfEncodedData = fdfEncodedData << name_b.GetBuffer(name_b.GetLength());
       name_b.ReleaseBuffer();
@@ skipping 54 matching lines @@
 }
 
 FX_BOOL CPDFSDK_InterForm::SubmitForm(const CFX_WideString& sDestination,
                                       FX_BOOL bUrlEncoded) {
   if (sDestination.IsEmpty())
     return FALSE;
 
   CPDFDoc_Environment* pEnv = m_pDocument->GetEnv();
   ASSERT(pEnv != NULL);
 
-  if (NULL == m_pDocument)
+  if (!m_pDocument)
     return FALSE;
   CFX_WideString wsPDFFilePath = m_pDocument->GetPath();
 
-  if (NULL == m_pInterForm)
+  if (!m_pInterForm)
     return FALSE;
   CFDF_Document* pFDFDoc = m_pInterForm->ExportToFDF(wsPDFFilePath);
-  if (NULL == pFDFDoc)
+  if (!pFDFDoc)
     return FALSE;
 
   CFX_ByteTextBuf FdfBuffer;
   FX_BOOL bRet = pFDFDoc->WriteBuf(FdfBuffer);
   delete pFDFDoc;
   if (!bRet)
     return FALSE;
 
   uint8_t* pBuffer = FdfBuffer.GetBuffer();
   FX_STRSIZE nBufSize = FdfBuffer.GetLength();
@@ skipping 425 matching lines @@
       break;
     }
   }
 }
 
 CPDF_Rect CBA_AnnotIterator::GetAnnotRect(CPDFSDK_Annot* pAnnot) {
   CPDF_Rect rcAnnot;
   pAnnot->GetPDFAnnot()->GetRect(rcAnnot);
   return rcAnnot;
 }