Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1411663013: Cleanup: Remove some NULL checks in fpdfsdk. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup: Remove some NULL checks in fpdfsdk. And simplify code. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ff5adbc0dfa71270a9979f0c3e1d27923c16218a

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : even simplier? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -50 lines) Patch
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 2 3 chunks +13 lines, -29 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
5 years, 1 month ago (2015-11-05 01:49:20 UTC) #3
Oliver Chang
lgtm
5 years, 1 month ago (2015-11-05 01:56:18 UTC) #4
Lei Zhang
And I uploaded a new patch set. Care to look again?
5 years, 1 month ago (2015-11-05 01:56:46 UTC) #5
Oliver Chang
lgtm lgtm again :)
5 years, 1 month ago (2015-11-05 02:01:02 UTC) #6
Lei Zhang
5 years, 1 month ago (2015-11-05 02:04:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
ff5adbc0dfa71270a9979f0c3e1d27923c16218a (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698