ipc/ipc_channel_posix.cc - Issue 1414503009: IPC: Remove unnecessary conversions of BrokerableAttachment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_posix.cc

Issue 1414503009: IPC: Remove unnecessary conversions of BrokerableAttachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from tsepez. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_channel_posix.cc

diff --git a/ipc/ipc_channel_posix.cc b/ipc/ipc_channel_posix.cc

index 85f4475c7ab761d8d747a134833e5857c9f41081..1f73e781f42f3dec441595192856307e16fa9202 100644

--- a/ipc/ipc_channel_posix.cc

+++ b/ipc/ipc_channel_posix.cc

@@ -697,7 +697,7 @@ bool ChannelPosix::ProcessMessageForDelivery(Message* message) {

if (message->HasBrokerableAttachments()) {

DCHECK(GetAttachmentBroker());

DCHECK(peer_pid_ != base::kNullProcessId);

- for (BrokerableAttachment* attachment :

+ for (const scoped_refptr<IPC::BrokerableAttachment>& attachment :

message->attachment_set()->GetBrokerableAttachments()) {

if (!GetAttachmentBroker()->SendAttachmentToProcess(attachment,

peer_pid_)) {

« no previous file with comments | « ipc/attachment_broker_unprivileged_win.cc ('k') | ipc/ipc_channel_reader.cc » ('j') | no next file with comments »