ipc/attachment_broker_unprivileged_win.cc - Issue 1414503009: IPC: Remove unnecessary conversions of BrokerableAttachment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/attachment_broker_unprivileged_win.cc

Issue 1414503009: IPC: Remove unnecessary conversions of BrokerableAttachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from tsepez. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/attachment_broker_unprivileged_win.cc

diff --git a/ipc/attachment_broker_unprivileged_win.cc b/ipc/attachment_broker_unprivileged_win.cc

index e1d9941f50782e916eeb461363c9925afb1b529b..9e9e7b2145528ab8d4a42801ed554554fea3a988 100644

--- a/ipc/attachment_broker_unprivileged_win.cc

+++ b/ipc/attachment_broker_unprivileged_win.cc

@@ -17,12 +17,12 @@ AttachmentBrokerUnprivilegedWin::AttachmentBrokerUnprivilegedWin() {}

AttachmentBrokerUnprivilegedWin::~AttachmentBrokerUnprivilegedWin() {}

bool AttachmentBrokerUnprivilegedWin::SendAttachmentToProcess(

- BrokerableAttachment* attachment,

+ const scoped_refptr<BrokerableAttachment>& attachment,

base::ProcessId destination_process) {

switch (attachment->GetBrokerableType()) {

case BrokerableAttachment::WIN_HANDLE: {

const internal::HandleAttachmentWin* handle_attachment =

- static_cast<const internal::HandleAttachmentWin*>(attachment);

+ static_cast<const internal::HandleAttachmentWin*>(attachment.get());

internal::HandleAttachmentWin::WireFormat format =

handle_attachment->GetWireFormat(destination_process);

return get_sender()->Send(

« no previous file with comments | « ipc/attachment_broker_unprivileged_win.h ('k') | ipc/ipc_channel_posix.cc » ('j') | no next file with comments »