ipc/ipc_channel_reader.cc - Issue 1414503009: IPC: Remove unnecessary conversions of BrokerableAttachment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_reader.cc

Issue 1414503009: IPC: Remove unnecessary conversions of BrokerableAttachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from tsepez. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_channel_reader.cc

diff --git a/ipc/ipc_channel_reader.cc b/ipc/ipc_channel_reader.cc

index 66e3f17528c4a8b777762baa464b15e15a1fadf6..86dde9de320fc84dfa83ca7cf746266c0d95f79e 100644

--- a/ipc/ipc_channel_reader.cc

+++ b/ipc/ipc_channel_reader.cc

@@ -250,9 +250,9 @@ ChannelReader::AttachmentIdSet ChannelReader::GetBrokeredAttachments(

#if USE_ATTACHMENT_BROKER

MessageAttachmentSet* set = msg->attachment_set();

- std::vector<BrokerableAttachment*> brokerable_attachments_copy =

- set->GetBrokerableAttachments();

- for (const BrokerableAttachment* attachment : brokerable_attachments_copy) {

+ std::vector<scoped_refptr<IPC::BrokerableAttachment>>

+ brokerable_attachments_copy(set->GetBrokerableAttachments());

+ for (const auto& attachment : brokerable_attachments_copy) {

if (attachment->NeedsBrokering()) {

AttachmentBroker* broker = GetAttachmentBroker();

DCHECK(broker);

« no previous file with comments | « ipc/ipc_channel_posix.cc ('k') | ipc/ipc_channel_reader_unittest.cc » ('j') | no next file with comments »