runtime/vm/debugger.h - Issue 1414493003: Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.h

Issue 1414493003: Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current … (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Zones and commentw Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger.h

diff --git a/runtime/vm/debugger.h b/runtime/vm/debugger.h

index a9d054728110c47e3f7a406daa872eb2cffb42bd..05155707f344fe2b65371b83de02c8f7653c8d99 100644

--- a/runtime/vm/debugger.h

+++ b/runtime/vm/debugger.h

@@ -650,7 +650,10 @@ class Debugger {

void HandleSteppingRequest(DebuggerStackTrace* stack_trace);

- Zone* zone() const { return isolate_->current_zone(); }

+ Zone* zone() const {

+ ASSERT(isolate_->MutatorThreadIsCurrentThread());

+ return isolate_->current_zone();

+ }

Isolate* isolate_;

Dart_Port isolate_id_; // A unique ID for the isolate in the debugger.

« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »