[GCM] Updating the list of restricted keys for GCM API messages

[GCM] Updating the list of restricted keys for GCM API messages

* ensuring that "goog." and "google" are case-insensitive
* adding "collapse_key" (case-sensitive)
* fixing a typo in error messages in gcm_api.cc and tests: occured -> occurred.

BUG=316683
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250868

[fgorski, 2014-02-11 23:51:04]

PTAL.

[jianli, 2014-02-12 01:30:32]

lgtm

https://codereview.chromium.org/141433030/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/gcm/gcm_api.cc (right):

https://codereview.chromium.org/141433030/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcm/gcm_api.cc:77: std::transform(key.begin(),
key.end(), lower.begin(), ::tolower);
nit: use base::StringToLowerASCII. Or even better, you could probably use
base::LowerCaseEqualsASCII

https://codereview.chromium.org/141433030/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/gcm.json (right):

https://codereview.chromium.org/141433030/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcm.json:80: "description": "Message data to send
to the server. Case-instensitive <code>goog.</code> and <code>google</code>, as
well as case-sensitive <code>collapse_key</code> are disallowed as key prefixes.
Sum of all key/value pairs should not exceed $(ref:gcm.MAX_MESSAGE_SIZE)."
typo

[not at google - send to devlin, 2014-02-12 01:42:23]

lgtm but you can TBR me on documentation changes. I did a drive-by nit anyway
but you can ignore me.

https://codereview.chromium.org/141433030/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/gcm/gcm_api.cc (right):

https://codereview.chromium.org/141433030/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcm/gcm_api.cc:26: const size_t kCollapseKeyLength
= arraysize(kCollapseKey) - 1;
I don't really understand why you can't inline these kFooLength as just
arraysize(kFoo) - 1, but, whatever.

[fgorski, 2014-02-12 21:52:22]

Thanks for the review, all comments were addressed.

https://codereview.chromium.org/141433030/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/gcm/gcm_api.cc (right):

https://codereview.chromium.org/141433030/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcm/gcm_api.cc:26: const size_t kCollapseKeyLength
= arraysize(kCollapseKey) - 1;
On 2014/02/12 01:42:23, kalman wrote:
> I don't really understand why you can't inline these kFooLength as just
> arraysize(kFoo) - 1, but, whatever.

Done.

https://codereview.chromium.org/141433030/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcm/gcm_api.cc:77: std::transform(key.begin(),
key.end(), lower.begin(), ::tolower);
On 2014/02/12 01:30:32, jianli wrote:
> nit: use base::StringToLowerASCII. Or even better, you could probably use
> base::LowerCaseEqualsASCII

Done.

https://codereview.chromium.org/141433030/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/gcm.json (right):

https://codereview.chromium.org/141433030/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcm.json:80: "description": "Message data to send
to the server. Case-instensitive <code>goog.</code> and <code>google</code>, as
well as case-sensitive <code>collapse_key</code> are disallowed as key prefixes.
Sum of all key/value pairs should not exceed $(ref:gcm.MAX_MESSAGE_SIZE)."
On 2014/02/12 01:30:32, jianli wrote:
> typo

Done.

[fgorski, 2014-02-12 21:53:02]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-02-12 21:55:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fgorski@chromium.org/141433030/80001

[commit-bot: I haz the power, 2014-02-13 00:36:57]

Change committed as 250868