chrome/common/extensions/api/gcm.json - Issue 141433030: [GCM] Updating the list of restricted keys for GCM API messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/gcm.json

Issue 141433030: [GCM] Updating the list of restricted keys for GCM API messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code reviews from jianli@ and kalman@, fixing a typo in error messages" Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/api/gcm.json

diff --git a/chrome/common/extensions/api/gcm.json b/chrome/common/extensions/api/gcm.json

index fbde146159192fcf4ea4e1d75705b04c0acf498e..c0c77341ba4a6b016a580b43c927125bd532751b 100644

--- a/chrome/common/extensions/api/gcm.json

+++ b/chrome/common/extensions/api/gcm.json

@@ -77,7 +77,7 @@

"type": "string",

"minLength": 1

- "description": "Message data to send to the server. <code>goog.</code> and <code>google</code> are disallowed as key prefixes. Sum of all key/value pairs should not exceed $(ref:gcm.MAX_MESSAGE_SIZE)."

+ "description": "Message data to send to the server. Case-insensitive <code>goog.</code> and <code>google</code>, as well as case-sensitive <code>collapse_key</code> are disallowed as key prefixes. Sum of all key/value pairs should not exceed $(ref:gcm.MAX_MESSAGE_SIZE)."

}

« no previous file with comments | « chrome/browser/extensions/api/gcm/gcm_api.cc ('k') | chrome/renderer/resources/extensions/gcm_custom_bindings.js » ('j') | no next file with comments »