chrome/renderer/resources/extensions/gcm_custom_bindings.js - Issue 141433030: [GCM] Updating the list of restricted keys for GCM API messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/gcm_custom_bindings.js

Issue 141433030: [GCM] Updating the list of restricted keys for GCM API messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code reviews from jianli@ and kalman@, fixing a typo in error messages" Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/gcm_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/gcm_custom_bindings.js b/chrome/renderer/resources/extensions/gcm_custom_bindings.js

index 8fcd698a87c9ce89a27f50650f04362d09ece293..fa3e5e4bcba5d41ef80c54a01e1dfccdf795bb86 100644

--- a/chrome/renderer/resources/extensions/gcm_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/gcm_custom_bindings.js

@@ -19,9 +19,11 @@ binding.registerCustomHook(function(bindingsAPI) {

if (property.length == 0)

throw new Error("One of data keys is empty.");

+ var lowerCasedProperty = property.toLowerCase();

// Issue an error for forbidden prefixes of property names.

- if (property.indexOf("goog.") == 0 ||

- property.indexOf("google") == 0) {

+ if (lowerCasedProperty.indexOf("goog.") == 0 ||

+ lowerCasedProperty.indexOf("google") == 0 ||

+ property.indexOf("collapse_key") == 0) {

throw new Error("Invalid data key: " + property);

}

« no previous file with comments | « chrome/common/extensions/api/gcm.json ('k') | chrome/test/data/extensions/api_test/gcm/events/on_send_error.js » ('j') | no next file with comments »