Use the new DrawHighlight() helper to replace GlowHoverController::Draw().

Use the new DrawHighlight() helper to replace GlowHoverController::Draw().

This also makes a behavioral change: we now draw the hover effect for background
tabs even when there is a custom theme.  In testing, I couldn't find a reason to
exclude custom themes; drawing the hover effect works fine and is as helpful as
it is on the default theme.

BUG=none
TEST=none

Committed: https://crrev.com/44f92d1b16b0d3b67f53469be5aa205e58cb0748
Cr-Commit-Position: refs/heads/master@{#358012}

[Peter Kasting, 2015-11-04 23:47:10]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[Peter Kasting, 2015-11-04 23:47:10]

https://codereview.chromium.org/1418563016/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/1418563016/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.cc:1231: const SkAlpha hover_alpha =
hover_controller_.GetAlpha();
If you're wondering why this block is way up here and not down below, it's
because my next change is going to refactor code such that we can avoid creating
|background_canvas| in the next statement if we're not drawing the hover effect,
and instead just draw directly to |canvas|.

[sky, 2015-11-05 03:27:16]

LGTM

https://codereview.chromium.org/1418563016/diff/20001/ui/views/controls/glow_...
File ui/views/controls/glow_hover_controller.cc (right):

https://codereview.chromium.org/1418563016/diff/20001/ui/views/controls/glow_...
ui/views/controls/glow_hover_controller.cc:7: #include
"third_party/skia/include/effects/SkGradientShader.h"
nit: nuke any includes that are now stale.

[Peter Kasting, 2015-11-05 06:25:17]

https://codereview.chromium.org/1418563016/diff/20001/ui/views/controls/glow_...
File ui/views/controls/glow_hover_controller.cc (right):

https://codereview.chromium.org/1418563016/diff/20001/ui/views/controls/glow_...
ui/views/controls/glow_hover_controller.cc:7: #include
"third_party/skia/include/effects/SkGradientShader.h"
On 2015/11/05 03:27:16, sky wrote:
> nit: nuke any includes that are now stale.

Good call, didn't even think of it.  Done.

[Peter Kasting, 2015-11-05 06:25:26]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2015-11-05 06:25:26]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1418563016/#ps40001
(title: "Nuke #includes")

[commit-bot: I haz the power, 2015-11-05 06:25:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418563016/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418563016/40001

[commit-bot: I haz the power, 2015-11-05 07:36:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-05 07:37:27]

Patchset 3 (id:??) landed as
https://crrev.com/44f92d1b16b0d3b67f53469be5aa205e58cb0748
Cr-Commit-Position: refs/heads/master@{#358012}