Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1413973002: Modifications to get 'blaze build -c opt //third_party/skia/HEAD/...' to work. (Closed)

Created:
5 years, 2 months ago by dogben
Modified:
5 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Modifications to get 'blaze build -c opt //third_party/skia/HEAD/...' to work. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7d974f5e4f8ded8834b58f560ac6e03aed370310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M BUILD.public View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkStream.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkTaskGroup.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/MatrixTest.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/SRGBReadWritePixelsTest.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dogben
For some reason the frame size check doesn't occur in fastbuild mode. It looks like ...
5 years, 2 months ago (2015-10-19 16:56:08 UTC) #2
mtklein
On 2015/10/19 16:56:08, Ben Wagner wrote: > For some reason the frame size check doesn't ...
5 years, 2 months ago (2015-10-19 17:56:21 UTC) #3
dogben
On 2015/10/19 at 17:56:21, mtklein wrote: > On 2015/10/19 16:56:08, Ben Wagner wrote: > > ...
5 years, 2 months ago (2015-10-19 18:16:46 UTC) #4
mtklein
lgtm
5 years, 2 months ago (2015-10-19 20:45:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413973002/1
5 years, 2 months ago (2015-10-19 20:46:36 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 20:55:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7d974f5e4f8ded8834b58f560ac6e03aed370310

Powered by Google App Engine
This is Rietveld 408576698