Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413643002: Separate RenderViewHost from RenderWidgetHost, part 2: public implementation. (Closed)

Created:
5 years, 2 months ago by Avi (use Gerrit)
Modified:
5 years, 2 months ago
Reviewers:
ncarter (slow), dcheng
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org, posciak+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, yurys, feature-media-reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, James Su, jdduke+watch_chromium.org, pfeldman, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate RenderViewHost from RenderWidgetHost, part 2: public implementation. This is the second part of the separation of RenderViewHost and RenderWidgetHost. BUG=542477 TEST=all green Committed: https://crrev.com/3627ecac5d720b442e5ee27829d064fdf55c8486 Cr-Commit-Position: refs/heads/master@{#354537}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -86 lines) Patch
M content/browser/browser_plugin/browser_plugin_embedder.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/frame_host/cross_process_frame_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 7 chunks +11 lines, -13 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 2 chunks +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413643002/1
5 years, 2 months ago (2015-10-16 14:58:34 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/94837)
5 years, 2 months ago (2015-10-16 15:07:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413643002/20001
5 years, 2 months ago (2015-10-16 16:11:25 UTC) #6
Avi (use Gerrit)
5 years, 2 months ago (2015-10-16 16:48:36 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 17:09:24 UTC) #10
ncarter (slow)
lgtm!!!
5 years, 2 months ago (2015-10-16 17:09:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413643002/20001
5 years, 2 months ago (2015-10-16 17:35:17 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 17:40:51 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 17:41:52 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3627ecac5d720b442e5ee27829d064fdf55c8486
Cr-Commit-Position: refs/heads/master@{#354537}

Powered by Google App Engine
This is Rietveld 408576698