Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 1413643002: Separate RenderViewHost from RenderWidgetHost, part 2: public implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc
index a79c95464064cb5e910a89bc17d1e194809b868a..eaec2fe34ac91e31ed57ff9dae98e58588ebf2f9 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest.cc
@@ -236,10 +236,11 @@ bool BrowserPluginGuest::OnMessageReceivedFromEmbedder(
RenderWidgetHostViewGuest* rwhv = static_cast<RenderWidgetHostViewGuest*>(
web_contents()->GetRenderWidgetHostView());
// Until the guest is attached, it should not be handling input events.
- if (attached() && rwhv && rwhv->OnMessageReceivedFromEmbedder(
+ if (attached() && rwhv &&
+ rwhv->OnMessageReceivedFromEmbedder(
message,
- static_cast<RenderViewHostImpl*>(
- embedder_web_contents()->GetRenderViewHost()))) {
+ RenderWidgetHostImpl::From(
+ embedder_web_contents()->GetRenderViewHost()->GetWidget()))) {
return true;
}
@@ -332,8 +333,8 @@ void BrowserPluginGuest::InitInternal(
DCHECK(GetWebContents()->GetRenderViewHost());
// Initialize the device scale factor by calling |NotifyScreenInfoChanged|.
- auto render_widget_host =
- RenderWidgetHostImpl::From(GetWebContents()->GetRenderViewHost());
+ auto render_widget_host = RenderWidgetHostImpl::From(
+ GetWebContents()->GetRenderViewHost()->GetWidget());
render_widget_host->NotifyScreenInfoChanged();
// TODO(chrishtr): this code is wrong. The navigate_on_drag_drop field will
@@ -948,10 +949,10 @@ void BrowserPluginGuest::OnUpdateGeometry(int browser_plugin_instance_id,
// The plugin has moved within the embedder without resizing or the
// embedder/container's view rect changing.
guest_window_rect_ = view_rect;
- RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>(
- GetWebContents()->GetRenderViewHost());
- if (rvh)
- rvh->SendScreenRects();
+ RenderWidgetHostImpl* rwh = RenderWidgetHostImpl::From(
+ GetWebContents()->GetRenderViewHost()->GetWidget());
+ if (rwh)
+ rwh->SendScreenRects();
}
void BrowserPluginGuest::OnHasTouchEventHandlers(bool accept) {

Powered by Google App Engine
This is Rietveld 408576698