content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 1413643002: Separate RenderViewHost from RenderWidgetHost, part 2: public implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 1413643002: Separate RenderViewHost from RenderWidgetHost, part 2: public implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/loader/resource_scheduler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc

index a6d04cde898ee2a6118990c8c7427b528d7cb1ec..771eb429b936bcd198c012e619151907a0fbb64d 100644

--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc

@@ -721,7 +721,7 @@ TEST_F(RenderFrameHostManagerTest, WhiteListSwapCompositorFrame) {

TestRenderFrameHost* swapped_out_rfh = CreateSwappedOutRenderFrameHost();

TestRenderWidgetHostView* swapped_out_rwhv =

static_cast<TestRenderWidgetHostView*>(

- swapped_out_rfh->GetRenderViewHost()->GetView());

+ swapped_out_rfh->GetRenderViewHost()->GetWidget()->GetView());

EXPECT_FALSE(swapped_out_rwhv->did_swap_compositor_frame());

MockRenderProcessHost* process_host = swapped_out_rfh->GetProcess();

@@ -1818,8 +1818,9 @@ TEST_F(RenderFrameHostManagerTest, NavigateWithEarlyClose) {

EXPECT_EQ(host2, GetPendingFrameHost(manager));

// 3) Close the tab. -------------------------

- notifications.ListenFor(NOTIFICATION_RENDER_WIDGET_HOST_DESTROYED,

- Source<RenderWidgetHost>(host2->render_view_host()));

+ notifications.ListenFor(

+ NOTIFICATION_RENDER_WIDGET_HOST_DESTROYED,

+ Source<RenderWidgetHost>(host2->render_view_host()->GetWidget()));

manager->OnBeforeUnloadACK(false, true, base::TimeTicks());

EXPECT_TRUE(

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/loader/resource_scheduler_unittest.cc » ('j') | no next file with comments »