Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413593007: Create SDL backed SkOSWindow (Closed)

Created:
5 years, 1 month ago by joshua.litt
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -333 lines) Patch
M gyp/views.gyp View 1 4 chunks +27 lines, -12 lines 0 comments Download
M include/gpu/gl/SkGLContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/views/SkOSWindow_SDL.h View 1 chunk +33 lines, -14 lines 0 comments Download
M src/views/sdl/SkOSWindow_SDL.cpp View 1 2 chunks +186 lines, -180 lines 0 comments Download
M third_party/libsdl/linux/README View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/libsdl/linux/SDL_config.h View 1 15 chunks +38 lines, -14 lines 0 comments Download
M third_party/libsdl/linux/sdl_linux.gypi View 1 2 chunks +105 lines, -11 lines 0 comments Download
M third_party/libsdl/sdl.gypi View 1 1 chunk +1 line, -7 lines 0 comments Download
D third_party/libsdl/sdl_sources.gypi View 1 1 chunk +0 lines, -92 lines 0 comments Download

Dependent Patchsets:

Issue 1415453009 Patch 1
Issue 1415453009 Patch 20001
Issue 1415453009 Patch 40001

Messages

Total messages: 7 (2 generated)
joshualitt
adding reed for SkOSWindow stuff, this works with sample app as well as visualbench, though ...
5 years, 1 month ago (2015-10-29 21:13:22 UTC) #2
joshualitt
On 2015/10/29 21:13:22, joshualitt wrote: > adding reed for SkOSWindow stuff, this works with sample ...
5 years, 1 month ago (2015-11-04 21:01:20 UTC) #3
reed1
lgtm
5 years, 1 month ago (2015-11-04 21:12:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413593007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413593007/40001
5 years, 1 month ago (2015-11-04 21:29:44 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 21:41:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/65d6fbb576b7f0c86e3124db92f302e09b6eea13

Powered by Google App Engine
This is Rietveld 408576698