Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415453009: Wire up SDL on Android (Closed)

Created:
5 years, 1 month ago by joshua.litt
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@sdl
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : small cleanup #

Patch Set 3 : tweaks #

Patch Set 4 : rebase onto master #

Patch Set 5 : fix appurify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2018 lines, -73 lines) Patch
M gyp/common_variables.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/views.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/visualbench.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkOSWindow_SDL.h View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M include/views/SkWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/apps/settings.gradle View 1 chunk +1 line, -0 lines 0 comments Download
A + platform_tools/android/apps/visualbenchsdl/build.gradle View 0 chunks +-1 lines, --1 lines 0 comments Download
A + platform_tools/android/apps/visualbenchsdl/src/main/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchActivity.java View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A + platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchTestActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A platform_tools/android/apps/visualbenchsdl/src/main/java/org/libsdl/app/SDLActivity.java View 1 2 1 chunk +1684 lines, -0 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
M src/views/sdl/SkOSWindow_SDL.cpp View 1 2 5 chunks +74 lines, -18 lines 0 comments Download
A third_party/libsdl/android/SDL_config.h View 1 chunk +145 lines, -0 lines 0 comments Download
A + third_party/libsdl/android/sdl_android.gypi View 1 2 4 chunks +22 lines, -48 lines 0 comments Download
M third_party/libsdl/sdl.gypi View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
joshualitt
This CL works, but it has some rough edges(such as getting a 2.0 context, and ...
5 years, 1 month ago (2015-11-05 16:06:11 UTC) #2
bsalomon
lgtm
5 years, 1 month ago (2015-11-05 16:08:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415453009/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415453009/60001
5 years, 1 month ago (2015-11-05 16:24:25 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/a4d3797c3b0f0cac8493c46cb334ca88a5d6ccf6
5 years, 1 month ago (2015-11-05 16:35:34 UTC) #7
joshualitt
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1410703009/ by joshualitt@google.com. ...
5 years, 1 month ago (2015-11-05 18:48:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415453009/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415453009/2
5 years, 1 month ago (2015-11-05 19:38:28 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 19:49:38 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 (id:2) as
https://skia.googlesource.com/skia/+/474a9ea051c584c373da28c5c8511f279ebd734c

Powered by Google App Engine
This is Rietveld 408576698