Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1413493003: Check the ServiceWorker Version ID in EmbeddedWorkerInstance::Start() in release builds. (Closed)

Created:
5 years, 2 months ago by horo
Modified:
5 years, 2 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check the ServiceWorker Version ID in EmbeddedWorkerInstance::Start() in release builds. We are receiving some crash reports which may be caused by the invalid ServiceWorker version ID. To eliminate the possibility of this, this cl adds ServiceWorker version ID CKECK() in EmbeddedWorkerInstance::Start. BUG=532420 Committed: https://crrev.com/8d91293cf2691903ae725a448a8170fc821fa9e3 Cr-Commit-Position: refs/heads/master@{#354470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
horo
nhiroki@ Could you please review this?
5 years, 2 months ago (2015-10-16 02:31:26 UTC) #2
nhiroki
lgtm
5 years, 2 months ago (2015-10-16 06:32:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413493003/1
5 years, 2 months ago (2015-10-16 06:39:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 08:04:01 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 08:04:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d91293cf2691903ae725a448a8170fc821fa9e3
Cr-Commit-Position: refs/heads/master@{#354470}

Powered by Google App Engine
This is Rietveld 408576698