Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 1413493003: Check the ServiceWorker Version ID in EmbeddedWorkerInstance::Start() in release builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index 5efdd30f358f41b7c9781cc6a234ebad86994196..840b84c6e74bd09a6aace30202685b8b25083099 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -149,6 +149,9 @@ void EmbeddedWorkerInstance::Start(int64 service_worker_version_id,
return;
}
DCHECK(status_ == STOPPED);
+ // TODO(horo): If we will see crashes here, we have to find the root cause of
+ // the invalid version ID. Otherwise change CHECK to DCHECK.
+ CHECK_NE(service_worker_version_id, kInvalidServiceWorkerVersionId);
start_timing_ = base::TimeTicks::Now();
status_ = STARTING;
starting_phase_ = ALLOCATING_PROCESS;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698