Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413463009: Implemented the Word64Clz TurboFan operator for x64, arm64, and mips64. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
ahaas1, titzer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implemented the Word64Clz TurboFan operator for x64, arm64, and mips64. R=titzer@chromium.org Committed: https://crrev.com/39ed694bbd3f8409c08df04a06fe139c87bc23b1 Cr-Commit-Position: refs/heads/master@{#31858}

Patch Set 1 #

Patch Set 2 : Fixed a typing problem, and added mips64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -4 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips64/constants-mips64.h View 1 4 chunks +6 lines, -0 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 2 chunks +15 lines, -1 line 0 comments Download
M src/mips64/simulator-mips64.cc View 1 2 chunks +18 lines, -3 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +74 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ahaas
5 years, 1 month ago (2015-11-05 17:33:01 UTC) #1
ahaas
I added issue https://codereview.chromium.org/1405283007/ to this one to resolve merge conflicts. Thanks to Paul Lind ...
5 years, 1 month ago (2015-11-06 08:41:10 UTC) #3
titzer
On 2015/11/06 08:41:10, ahaas wrote: > I added issue https://codereview.chromium.org/1405283007/ to this one to resolve ...
5 years, 1 month ago (2015-11-06 12:27:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413463009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413463009/20001
5 years, 1 month ago (2015-11-06 14:46:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 14:50:48 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 14:51:28 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/39ed694bbd3f8409c08df04a06fe139c87bc23b1
Cr-Commit-Position: refs/heads/master@{#31858}

Powered by Google App Engine
This is Rietveld 408576698