Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: test/cctest/test-api.cc

Issue 1413123004: Reland "Use C++ implementation of Object.definePropert{y,ies}" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixes for access checks and interceptors Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/property-descriptor.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index f8edb2b5a444304a99c35224a6e859442d9c039f..7d544251a4911ab1268fc3014961ca58302ebb7a 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -8727,10 +8727,12 @@ TEST(AccessControlES5) {
CompileRun("other.accessible_prop = 42");
CHECK_EQ(42, g_echo_value);
- v8::Handle<Value> value;
- CompileRun("Object.defineProperty(other, 'accessible_prop', {value: -1})");
- value = CompileRun("other.accessible_prop == 42");
- CHECK(value->IsTrue());
+ // [[DefineOwnProperty]] always throws for access-checked objects.
+ CHECK(
+ CompileRun("Object.defineProperty(other, 'accessible_prop', {value: 43})")
+ .IsEmpty());
+ CHECK(CompileRun("other.accessible_prop == 42")->IsTrue());
+ CHECK_EQ(42, g_echo_value); // Make sure we didn't call the setter.
}
« no previous file with comments | « src/property-descriptor.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698